Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2323093002: Dummy WebGestureEvent() sent to SendGestureScrollEvent() needs proper type. (Closed)

Created:
4 years, 3 months ago by wjmaclean
Modified:
4 years, 3 months ago
Reviewers:
kenrb, Charlie Reis
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Dummy WebGestureEvent() sent to SendGestureScrollEvent() needs proper type. At present, debug builds of Chrome can crash if your touch scrolling in a cross-site iframe with --site-per-process enabled, and then you tap in the parent frame. This happens when a 'dummy' WebGestureEvent is sent to RenderWidgetHostInputEventRouter::SendGestureScrollEvent() without defining its type. Since the function DCHECKs the type of the input event, this causes a crash. This CL makes sure the event has an appropriate type. BUG=645208 Committed: https://crrev.com/1e99661f52c63318493bb12f05701405da3b42ea Cr-Commit-Position: refs/heads/master@{#417566}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M content/browser/renderer_host/render_widget_host_input_event_router.cc View 4 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
wjmaclean
Tiny fix-up ... ptal?
4 years, 3 months ago (2016-09-08 20:33:05 UTC) #4
kenrb
lgtm
4 years, 3 months ago (2016-09-08 21:01:32 UTC) #6
Charlie Reis
LGTM
4 years, 3 months ago (2016-09-08 21:12:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323093002/1
4 years, 3 months ago (2016-09-09 12:33:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 12:37:28 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 12:39:40 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e99661f52c63318493bb12f05701405da3b42ea
Cr-Commit-Position: refs/heads/master@{#417566}

Powered by Google App Engine
This is Rietveld 408576698