mash: Port sysui's WallpaperDelegateMus to mojo:ash.

ash/common/wallpaper/wallpaper_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/wallpaper/wallpaper_controller.h"
 
 #include "ash/common/shell_window_ids.h"
 #include "ash/common/wallpaper/wallpaper_controller_observer.h"
 #include "ash/common/wallpaper/wallpaper_delegate.h"
 #include "ash/common/wallpaper/wallpaper_view.h"
@@ skipping 133 matching lines @@
 
   // Note that |shell| is null when this is called from Chrome running in Mash.
   WmShell* shell = WmShell::Get();
 
   gfx::Size max;
   for (const auto& display : display::Screen::GetScreen()->GetAllDisplays()) {
     // Use the native size, not ManagedDisplayInfo::size_in_pixel or
     // Display::size.
     // TODO(msw): Avoid using Display::size here; see http://crbug.com/613657.
     gfx::Size size = display.size();
-    if (shell)
-      size = shell->GetDisplayInfo(display.id()).bounds_in_native().size();
+    if (shell) {
+      display::ManagedDisplayInfo info = shell->GetDisplayInfo(display.id());
+      // TODO(mash): Mash returns a fake ManagedDisplayInfo. crbug.com/622480

[sky, 2016/09/09 22:17:01]

Is wallpaper the only place that needs ManagedDisplayInfo? If so, how about
providing methods for the specific data you need on WmShell rather than the more
generic ManagedDisplayInfo.

[msw, 2016/09/09 23:09:51]

No, many places currently use ManagedDisplayInfo. It seems like the path forward
for these workarounds are probably to move ManagedDisplayInfo::bounds_in_native
to display::Display, and just use display::Display::rotation(). I'd like to
address those in followup patches, unrelated to WallpaperDelegateMus.

[sky, 2016/09/09 23:36:35]

Ok, sounds reasonable to me to address fetching the ManagedDisplayInfo
separately. It may make sense to send it in the WindowManager interface if that
is the only place that needs it.

+      if (info.id() == display.id())
+        size = info.bounds_in_native().size();
+    }
     if (display.rotation() == display::Display::ROTATE_90 ||
         display.rotation() == display::Display::ROTATE_270) {
       size = gfx::Size(size.height(), size.width());
     }
     max.SetToMax(size);
   }
 
   return max;
 }
 
@@ skipping 74 matching lines @@
   return locked ? kShellWindowId_LockScreenWallpaperContainer
                 : kShellWindowId_WallpaperContainer;
 }
 
 void WallpaperController::UpdateWallpaper(bool clear_cache) {
   current_wallpaper_.reset();
   WmShell::Get()->wallpaper_delegate()->UpdateWallpaper(clear_cache);
 }
 
 }  // namespace ash