chrome/browser/chromeos/arc/arc_optin_uma.h - Issue 2323043003: arc: Add a global 5 minute timeout for ARC opt-in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/arc/arc_optin_uma.h

Issue 2323043003: arc: Add a global 5 minute timeout for ARC opt-in (Closed)

Patch Set: Removed obsolete comment, useless function. Added histogram string. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/arc/arc_optin_uma.h

diff --git a/chrome/browser/chromeos/arc/arc_optin_uma.h b/chrome/browser/chromeos/arc/arc_optin_uma.h

index 5955f6f6ad48f95aa5e95adc7b798714602febab..18cc72570239b578248e87b0edc7974b5f63c814 100644

--- a/chrome/browser/chromeos/arc/arc_optin_uma.h

+++ b/chrome/browser/chromeos/arc/arc_optin_uma.h

@@ -75,6 +75,9 @@ enum class ProvisioningResult : int {

// ARC instance is stopped during the sign in procedure.

ARC_STOPPED = 16,

+ // Overall sign in timeout.

Yusuke Sato 2016/09/09 03:28:57 nit: This comment does not add any info at all, bu

Luis Héctor Chávez 2016/09/09 03:37:24 Found a way to improve it slightly without being t

+ OVERALL_SIGN_IN_TIMEOUT = 17,

// The size of this enum; keep last.

SIZE,

};