Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: tests/ColorSpaceTest.cpp

Issue 2323003002: Cache the inverse matrix on SkColorSpace. Rename xyz() to toXYZ(). (Closed)
Patch Set: Remove xyz() again Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/gpu/GrColorSpaceXform.cpp ('k') | tests/SurfaceTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 Google Inc. 2 * Copyright 2016 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "Resources.h" 8 #include "Resources.h"
9 #include "SkCodec.h" 9 #include "SkCodec.h"
10 #include "SkColorSpace.h" 10 #include "SkColorSpace.h"
11 #include "SkColorSpace_Base.h" 11 #include "SkColorSpace_Base.h"
12 #include "Test.h" 12 #include "Test.h"
13 13
14 #include "png.h" 14 #include "png.h"
15 15
16 static bool almost_equal(float a, float b) { 16 static bool almost_equal(float a, float b) {
17 return SkTAbs(a - b) < 0.001f; 17 return SkTAbs(a - b) < 0.001f;
18 } 18 }
19 19
20 static void test_space(skiatest::Reporter* r, SkColorSpace* space, 20 static void test_space(skiatest::Reporter* r, SkColorSpace* space,
21 const float red[], const float green[], const float blue[ ], 21 const float red[], const float green[], const float blue[ ],
22 const SkGammaNamed expectedGamma) { 22 const SkGammaNamed expectedGamma) {
23 23
24 REPORTER_ASSERT(r, nullptr != space); 24 REPORTER_ASSERT(r, nullptr != space);
25 REPORTER_ASSERT(r, expectedGamma == as_CSB(space)->gammaNamed()); 25 REPORTER_ASSERT(r, expectedGamma == as_CSB(space)->gammaNamed());
26 26
27 const SkMatrix44& mat = space->xyz(); 27 const SkMatrix44& mat = space->toXYZD50();
28 const float src[] = { 28 const float src[] = {
29 1, 0, 0, 1, 29 1, 0, 0, 1,
30 0, 1, 0, 1, 30 0, 1, 0, 1,
31 0, 0, 1, 1, 31 0, 0, 1, 1,
32 }; 32 };
33 float dst[4]; 33 float dst[4];
34 for (int i = 0; i < 3; ++i) { 34 for (int i = 0; i < 3; ++i) {
35 mat.mapScalars(&src[i*4], dst); 35 mat.mapScalars(&src[i*4], dst);
36 REPORTER_ASSERT(r, almost_equal(red[i], dst[0])); 36 REPORTER_ASSERT(r, almost_equal(red[i], dst[0]));
37 REPORTER_ASSERT(r, almost_equal(green[i], dst[1])); 37 REPORTER_ASSERT(r, almost_equal(green[i], dst[1]));
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 GetResourcePath("icc_profiles/HP_ZR30w.icc").c_str()); 135 GetResourcePath("icc_profiles/HP_ZR30w.icc").c_str());
136 REPORTER_ASSERT(r, monitorData); 136 REPORTER_ASSERT(r, monitorData);
137 if (!monitorData) { 137 if (!monitorData) {
138 return; 138 return;
139 } 139 }
140 sk_sp<SkColorSpace> monitorSpace = SkColorSpace::NewICC(monitorData->data(), 140 sk_sp<SkColorSpace> monitorSpace = SkColorSpace::NewICC(monitorData->data(),
141 monitorData->size()) ; 141 monitorData->size()) ;
142 sk_sp<SkData> newMonitorData = ColorSpaceTest::WriteToICC(monitorSpace.get() ); 142 sk_sp<SkData> newMonitorData = ColorSpaceTest::WriteToICC(monitorSpace.get() );
143 sk_sp<SkColorSpace> newMonitorSpace = SkColorSpace::NewICC(newMonitorData->d ata(), 143 sk_sp<SkColorSpace> newMonitorSpace = SkColorSpace::NewICC(newMonitorData->d ata(),
144 newMonitorData->s ize()); 144 newMonitorData->s ize());
145 REPORTER_ASSERT(r, monitorSpace->xyz() == newMonitorSpace->xyz()); 145 REPORTER_ASSERT(r, monitorSpace->toXYZD50() == newMonitorSpace->toXYZD50());
146 REPORTER_ASSERT(r, as_CSB(monitorSpace)->gammaNamed() == as_CSB(newMonitorSp ace)->gammaNamed()); 146 REPORTER_ASSERT(r, as_CSB(monitorSpace)->gammaNamed() == as_CSB(newMonitorSp ace)->gammaNamed());
147 } 147 }
148 148
149 DEF_TEST(ColorSpace_Named, r) { 149 DEF_TEST(ColorSpace_Named, r) {
150 const struct { 150 const struct {
151 SkColorSpace::Named fNamed; 151 SkColorSpace::Named fNamed;
152 bool fIsSRGB; 152 bool fIsSRGB;
153 } recs[] { 153 } recs[] {
154 { SkColorSpace::kSRGB_Named, true }, 154 { SkColorSpace::kSRGB_Named, true },
155 { SkColorSpace::kAdobeRGB_Named, false }, 155 { SkColorSpace::kAdobeRGB_Named, false },
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 REPORTER_ASSERT(r, !SkColorSpace::Equals(srgb.get(), nullptr)); 242 REPORTER_ASSERT(r, !SkColorSpace::Equals(srgb.get(), nullptr));
243 REPORTER_ASSERT(r, !SkColorSpace::Equals(adobe.get(), srgb.get())); 243 REPORTER_ASSERT(r, !SkColorSpace::Equals(adobe.get(), srgb.get()));
244 REPORTER_ASSERT(r, !SkColorSpace::Equals(z30.get(), srgb.get())); 244 REPORTER_ASSERT(r, !SkColorSpace::Equals(z30.get(), srgb.get()));
245 REPORTER_ASSERT(r, !SkColorSpace::Equals(z32.get(), z30.get())); 245 REPORTER_ASSERT(r, !SkColorSpace::Equals(z32.get(), z30.get()));
246 REPORTER_ASSERT(r, !SkColorSpace::Equals(upperLeft.get(), srgb.get())); 246 REPORTER_ASSERT(r, !SkColorSpace::Equals(upperLeft.get(), srgb.get()));
247 REPORTER_ASSERT(r, !SkColorSpace::Equals(upperLeft.get(), upperRight.get())) ; 247 REPORTER_ASSERT(r, !SkColorSpace::Equals(upperLeft.get(), upperRight.get())) ;
248 REPORTER_ASSERT(r, !SkColorSpace::Equals(z30.get(), upperRight.get())); 248 REPORTER_ASSERT(r, !SkColorSpace::Equals(z30.get(), upperRight.get()));
249 REPORTER_ASSERT(r, !SkColorSpace::Equals(upperRight.get(), adobe.get())); 249 REPORTER_ASSERT(r, !SkColorSpace::Equals(upperRight.get(), adobe.get()));
250 REPORTER_ASSERT(r, !SkColorSpace::Equals(rgb1.get(), rgb2.get())); 250 REPORTER_ASSERT(r, !SkColorSpace::Equals(rgb1.get(), rgb2.get()));
251 } 251 }
OLDNEW
« no previous file with comments | « src/gpu/GrColorSpaceXform.cpp ('k') | tests/SurfaceTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698