typ/runner.py - Issue 2322963004: Clean up formatting, rework run wrapper script to not use globals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: typ/runner.py

Issue 2322963004: Clean up formatting, rework run wrapper script to not use globals. (Closed)

Patch Set: update w/ review feedback, lint Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: typ/runner.py

diff --git a/typ/runner.py b/typ/runner.py

index 7f5aeed6cf18fc4c9da541b8de026d350f7cd8bb..4d64b78027583dea405e27a62fd664f1a49dcd0f 100644

--- a/typ/runner.py

+++ b/typ/runner.py

@@ -357,8 +357,8 @@ class Runner(object):

total_shards = args.total_shards

assert total_shards >= 1

assert shard_index >= 0 and shard_index < total_shards, (

- 'shard_index (%d) must be >= 0 and < total_shards (%d)' %

- (shard_index, total_shards))

+ 'shard_index (%d) must be >= 0 and < total_shards (%d)' %

+ (shard_index, total_shards))

test_set.parallel_tests = _sort_inputs(

test_set.parallel_tests)[shard_index::total_shards]

test_set.isolated_tests = _sort_inputs(

@@ -407,6 +407,8 @@ class Runner(object):

add_tests(suite)

else:

add_tests(loader.loadTestsFromName(name))

+ # pylint: disable=no-member

if hasattr(loader, 'errors') and loader.errors:

# In Python3's version of unittest, loader failures get converted

# into failed test cases, rather than raising exceptions. However,

« no previous file with comments | « typ/fakes/test_result_server_fake.py ('k') | typ/tests/main_test.py » ('j') | no next file with comments »