Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2322963002: Remove the Android policy cache (Closed)

Created:
4 years, 3 months ago by aberent
Modified:
4 years, 3 months ago
CC:
chromium-reviews, dgn
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the Android policy cache The Android policy cache was originally created to avoid Strict Mode violations, but doesn't do so in Webview. Actually, although reading the app restrictions on the UI thread is a strict mode violation it is unlikely to cause UI visible delays, As such the solution is to simply to allow file reads in this component. BUG=628627 Committed: https://crrev.com/e4795a72b9d0c53c0e32911f1562a432e0ad4ee7 Cr-Commit-Position: refs/heads/master@{#418818}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -108 lines) Patch
M components/policy/android/java/src/org/chromium/policy/AbstractAppRestrictionsProvider.java View 4 chunks +11 lines, -78 lines 0 comments Download
M components/policy/android/junit/src/org/chromium/policy/AbstractAppRestrictionsProviderTest.java View 4 chunks +0 lines, -30 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
aberent
bauerb@ - full review please pastarmovj@ - OWNER review please.
4 years, 3 months ago (2016-09-08 13:32:06 UTC) #2
Bernhard Bauer
lgtm
4 years, 3 months ago (2016-09-08 13:37:59 UTC) #5
aberent
On 2016/09/08 13:37:59, Bernhard Bauer wrote: > lgtm pastarmov@ - I am still looking for ...
4 years, 3 months ago (2016-09-13 18:15:55 UTC) #8
pastarmovj
lgtm sorry I thought Bernhard had the super powers :)
4 years, 3 months ago (2016-09-13 18:35:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322963002/1
4 years, 3 months ago (2016-09-15 09:30:34 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 10:02:47 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 10:05:04 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4795a72b9d0c53c0e32911f1562a432e0ad4ee7
Cr-Commit-Position: refs/heads/master@{#418818}

Powered by Google App Engine
This is Rietveld 408576698