Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2322923002: [arm] Fix arm assembler test 4. (Closed)

Created:
4 years, 3 months ago by Rodolph Perfetta (ARM)
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM] Fix arm assembler test 4. The test was using some callee saved registers but tests don't save those. BUG=v8:5354 Committed: https://crrev.com/eea147fc2c7b053214abd5fd4f55918cedcb844c Cr-Commit-Position: refs/heads/master@{#39275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M test/cctest/test-assembler-arm.cc View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Rodolph Perfetta (ARM)
Fix for issue 5354
4 years, 3 months ago (2016-09-08 07:58:07 UTC) #2
Benedikt Meurer
LGTM, thanks
4 years, 3 months ago (2016-09-08 08:55:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322923002/1
4 years, 3 months ago (2016-09-08 11:23:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 11:51:07 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 11:51:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eea147fc2c7b053214abd5fd4f55918cedcb844c
Cr-Commit-Position: refs/heads/master@{#39275}

Powered by Google App Engine
This is Rietveld 408576698