Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2322883003: Nukes ash.gyp (Closed)

Created:
4 years, 3 months ago by sky
Modified:
4 years, 3 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Nukes ash.gyp I'm going to separate out tests into their own BUILD.gn, but want to start here first. BUG=none TEST=none R=msw@chromium.org Committed: https://crrev.com/2cab91d2a4562e4fa6bad980374a635bb0507967 Cr-Commit-Position: refs/heads/master@{#417436}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1088 lines, -1550 lines) Patch
M ash/BUILD.gn View 9 chunks +1088 lines, -23 lines 0 comments Download
D ash/ash.gyp View 1 chunk +0 lines, -1527 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sky
4 years, 3 months ago (2016-09-08 21:21:43 UTC) #2
msw
nice! lgtm
4 years, 3 months ago (2016-09-08 21:42:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322883003/1
4 years, 3 months ago (2016-09-08 21:45:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 23:43:01 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 23:47:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2cab91d2a4562e4fa6bad980374a635bb0507967
Cr-Commit-Position: refs/heads/master@{#417436}

Powered by Google App Engine
This is Rietveld 408576698