Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4542)

Unified Diff: blimp/client/core/settings/android/blimp_settings_android.cc

Issue 2322843002: Propagate connection info to Blimp android UI. (Closed)
Patch Set: Remove BlimpStringUtil after discussion of string res files. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/settings/android/blimp_settings_android.cc
diff --git a/blimp/client/core/settings/android/blimp_settings_android.cc b/blimp/client/core/settings/android/blimp_settings_android.cc
index 993b15503d8ba574bc887c48821d7261338fa800..4ce825535ce82d621ec3ebc71d5c88a9892f56b1 100644
--- a/blimp/client/core/settings/android/blimp_settings_android.cc
+++ b/blimp/client/core/settings/android/blimp_settings_android.cc
@@ -4,6 +4,10 @@
#include "blimp/client/core/settings/android/blimp_settings_android.h"
+#include "base/android/jni_string.h"
+#include "base/bind.h"
+#include "blimp/client/core/session/connection_status.h"
+#include "blimp/client/core/settings/blimp_settings_delegate.h"
#include "blimp/client/public/blimp_client_context.h"
#include "jni/AboutBlimpPreferences_jni.h"
@@ -27,8 +31,7 @@ static jlong Init(JNIEnv* env,
return reinterpret_cast<intptr_t>(new BlimpSettingsAndroid(env, jobj));
}
-BlimpSettingsAndroid::BlimpSettingsAndroid(JNIEnv* env, jobject jobj)
- : identity_source_(nullptr) {
+BlimpSettingsAndroid::BlimpSettingsAndroid(JNIEnv* env, jobject jobj) {
java_obj_.Reset(env, jobj);
}
@@ -40,21 +43,31 @@ BlimpSettingsAndroid::~BlimpSettingsAndroid() {
void BlimpSettingsAndroid::Destroy(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& jobj) {
- DCHECK(identity_source_);
- identity_source_->RemoveObserver(this);
+ if (delegate_) {
+ delegate_->GetIdentitySource()->RemoveObserver(this);
+ delegate_->GetConnectionStatus()->RemoveObserver(this);
+ }
+
delete this;
}
-void BlimpSettingsAndroid::SetIdentitySource(IdentitySource* identity_source) {
- if (identity_source_) {
- identity_source_->RemoveObserver(this);
- }
-
- identity_source_ = identity_source;
- DCHECK(identity_source_);
+void BlimpSettingsAndroid::SetDelegate(BlimpSettingsDelegate* delegate) {
+ // Set the Delegate, it can only get called for once.
+ DCHECK(!delegate_ && delegate);
+ delegate_ = delegate;
// Listen to sign in state change.
- identity_source->AddObserver(this);
+ delegate_->GetIdentitySource()->AddObserver(this);
+
+ // Listen to connection state change.
+ ConnectionStatus* conn_status = delegate_->GetConnectionStatus();
+ DCHECK(conn_status);
+ conn_status->AddObserver(this);
+
+ // Propagate connection info if the client is connected to the engine.
+ if (conn_status->IsConnected() && conn_status->IsValid()) {
+ OnConnected();
+ }
}
void BlimpSettingsAndroid::OnSignedOut() {
@@ -75,5 +88,22 @@ void BlimpSettingsAndroid::OnActiveAccountLogin() {
OnSignedIn();
}
+void BlimpSettingsAndroid::OnConnected() {
+ DCHECK(delegate_);
+
+ JNIEnv* env = base::android::AttachCurrentThread();
+ std::string ip =
+ delegate_->GetConnectionStatus()->GetIpEndPoint().address().ToString();
+ base::android::ScopedJavaLocalRef<jstring> jengine_ip(
+ base::android::ConvertUTF8ToJavaString(env, ip));
+
+ Java_AboutBlimpPreferences_onConnected(env, java_obj_, jengine_ip);
+}
+
+void BlimpSettingsAndroid::OnDisconnected(int result) {
+ JNIEnv* env = base::android::AttachCurrentThread();
+ Java_AboutBlimpPreferences_onDisconnected(env, java_obj_);
+}
+
} // namespace client
} // namespace blimp

Powered by Google App Engine
This is Rietveld 408576698