chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java - Issue 2322833002: Support serving offline page by offline ID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

Issue 2322833002: Support serving offline page by offline ID (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_request_job.h » ('j') | chrome/browser/android/offline_pages/offline_page_request_job.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

index f36c26bf43fd613b43d6bc89129571a0bc926766..2f0ede0f5948a6d5cdc417e759e36fd505e21eb3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

@@ -175,7 +175,7 @@ public class OfflinePageDownloadBridge implements DownloadServiceDelegate, Offli

LoadUrlParams params = new LoadUrlParams(item.getUrl());

Map<String, String> headers = new HashMap<String, String>();

- headers.put("X-Chrome-offline", "reason=download");

+ headers.put("X-Chrome-offline", "reason=download namespace=download id=" + guid);

Dmitry Titov 2016/09/09 04:33:06 no need to pass namespace here, guid is unique alr

jianli 2016/09/10 00:56:03 Changed to pass id per discussion.

params.setExtraHeaders(headers);

AsyncTabCreationParams asyncParams = componentName == null

? new AsyncTabCreationParams(params)