Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: chrome/browser/ui/views/validation_message_bubble_delegate.cc

Issue 23228004: Prepare to use gfx::RenderText in views::Label. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revert Label implementation changes. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/tabs/tab.cc ('k') | ui/gfx/render_text.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/validation_message_bubble_delegate.cc
diff --git a/chrome/browser/ui/views/validation_message_bubble_delegate.cc b/chrome/browser/ui/views/validation_message_bubble_delegate.cc
index 7c11a10a5cc262f8fdad85a62bb5d9bef093b387..0e857faf0c9ef6260cec5025e1db7b47c312f6f2 100644
--- a/chrome/browser/ui/views/validation_message_bubble_delegate.cc
+++ b/chrome/browser/ui/views/validation_message_bubble_delegate.cc
@@ -38,7 +38,6 @@ ValidationMessageBubbleDelegate::ValidationMessageBubbleDelegate(
views::Label* label = new views::Label(
main_text, bundle.GetFontList(ui::ResourceBundle::MediumFont));
label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
- label->set_directionality_mode(gfx::DIRECTIONALITY_FROM_TEXT);
int text_start_x = kPadding + size.width() + kIconTextMargin;
int min_available = kWindowMinWidth - text_start_x - kPadding;
int max_available = kWindowMaxWidth - text_start_x - kPadding;
@@ -50,7 +49,6 @@ ValidationMessageBubbleDelegate::ValidationMessageBubbleDelegate(
if (!sub_text.empty()) {
sub_label = new views::Label(sub_text);
sub_label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
- sub_label->set_directionality_mode(gfx::DIRECTIONALITY_FROM_TEXT);
label_width = std::max(label_width, sub_label->GetPreferredSize().width());
sub_label->SetMultiLine(true);
AddChildView(sub_label);
« no previous file with comments | « chrome/browser/ui/views/tabs/tab.cc ('k') | ui/gfx/render_text.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698