chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc - Issue 23228004: Prepare to use gfx::RenderText in views::Label.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 23228004: Prepare to use gfx::RenderText in views::Label. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revert Label implementation changes. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

index 09b1ba39f3dcc76373109b124ec92cd98730421d..b57da12808a6b9e20197040f79a12d030101d074 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

@@ -171,7 +171,6 @@ class BookmarkButtonBase : public views::LabelButton {

BookmarkButtonBase(views::ButtonListener* listener,

const base::string16& title)

: LabelButton(listener, title) {

- SetDirectionalityMode(gfx::DIRECTIONALITY_FROM_TEXT);

SetElideBehavior(kElideBehavior);

show_animation_.reset(new gfx::SlideAnimation(this));

if (!animations_enabled) {

@@ -282,7 +281,6 @@ class BookmarkFolderButton : public views::MenuButton {

views::MenuButtonListener* menu_button_listener,

bool show_menu_marker)

: MenuButton(listener, title, menu_button_listener, show_menu_marker) {

- SetDirectionalityMode(gfx::DIRECTIONALITY_FROM_TEXT);

SetElideBehavior(kElideBehavior);

show_animation_.reset(new gfx::SlideAnimation(this));

if (!animations_enabled) {