[Offline Pages] Fix flaky test due to actual loading of database.

[Offline Pages] Fix flaky test due to actual loading of database.

The flaky was due to the issue when trying to load OfflinePageModel, it
would crash with SQLite Error 1802. Fixed by mock the OfflinePageModel
if we're in a testing environment.

BUG=644570
Committed: https://crrev.com/dd2258ce9e678e3bdbcfe814649851882dfe8118
Cr-Commit-Position: refs/heads/master@{#417465}

[romax, 2016-09-08 00:26:21]

The CQ bit was checked by romax@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 00:26:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 00:30:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 00:30:14]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[romax, 2016-09-08 01:10:39]

The CQ bit was checked by romax@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 01:11:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 02:17:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 02:17:33]

Dry run: This issue passed the CQ dry run.

[romax, 2016-09-08 17:09:44]

romax@chromium.org changed reviewers:
+ dimich@chromium.org, thestig@chromium.org

[romax, 2016-09-08 17:09:45]

thestig@chromium.org: Please review changes in chrome

dimich@chromium.org: Please review changes in components/

Please let me know if it's not appropriate to put stub* as part of the
offline_pages target.

Thanks!

[Dmitry Titov, 2016-09-08 17:16:54]

It's better to avoid adding the test code to the non-test target.
Perhaps you want to add offline_pages' test target to the dependencies of the
test target that builds the test you are fixing?

[fgorski, 2016-09-08 17:18:56]

fgorski@chromium.org changed reviewers:
+ fgorski@chromium.org

[fgorski, 2016-09-08 17:18:57]

drive by based on discussion

https://codereview.chromium.org/2322793003/diff/40001/chrome/browser/android/...
File chrome/browser/android/offline_pages/offline_page_model_factory.cc (right):

https://codereview.chromium.org/2322793003/diff/40001/chrome/browser/android/...
chrome/browser/android/offline_pages/offline_page_model_factory.cc:23:
std::unique_ptr<KeyedService> BuildMockOfflinePageModelFactory(
how about moving this to testing_profile and appropriately sorting out the deps,
per our discussion.

[romax, 2016-09-08 17:56:59]

updated per comments.
PTAL, thanks!

[fgorski, 2016-09-08 18:07:28]

test/BUILD.gn may need to be updated.

[romax, 2016-09-08 18:12:40]

The CQ bit was checked by romax@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 18:13:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 18:17:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 18:17:26]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[romax, 2016-09-08 18:29:09]

The CQ bit was checked by romax@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 18:29:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-09-08 19:12:11]

Please consider asking chrome/browser/android/offline_pages/OWNERS +
chrome/test/base/OWNERS next time.

https://codereview.chromium.org/2322793003/diff/120001/chrome/test/base/testi...
File chrome/test/base/testing_profile.cc (right):

https://codereview.chromium.org/2322793003/diff/120001/chrome/test/base/testi...
chrome/test/base/testing_profile.cc:52: #include "chrome/common/features.h"
Is this needed?

[romax, 2016-09-08 19:22:35]

The CQ bit was checked by romax@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 19:23:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[romax, 2016-09-08 20:42:18]

The CQ bit was checked by romax@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 20:42:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dmitry Titov, 2016-09-08 20:53:29]

lgtm

It'd be better to "Publish+Mail Comments" after you upload updated patch so
there is a positive confirmation that the CL is ready for another look. People
usually either reply to comments with "Done" or put a short note ("PTAL") into
such reply. Just uploading a patch does not send any signal to reviewers...

[Lei Zhang, 2016-09-08 21:07:25]

rs lgtm

[commit-bot: I haz the power, 2016-09-08 22:34:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 22:34:27]

Dry run: This issue passed the CQ dry run.

[romax, 2016-09-08 23:07:42]

Thanks for the comments and the tip. I wasn't sending out emails since I wanted
to do a dry-run first, since another building platform may report something to
fix :)

Thanks!

[romax, 2016-09-09 00:10:59]

The CQ bit was checked by romax@chromium.org

[commit-bot: I haz the power, 2016-09-09 00:11:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 00:53:21]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-09-09 00:55:43]

Description was changed from

==========
[Offline Pages] Fix flaky test due to actual loading of database.

The flaky was due to the issue when trying to load OfflinePageModel, it
would crash with SQLite Error 1802. Fixed by mock the OfflinePageModel
if we're in a testing environment.

BUG=644570
==========

to

==========
[Offline Pages] Fix flaky test due to actual loading of database.

The flaky was due to the issue when trying to load OfflinePageModel, it
would crash with SQLite Error 1802. Fixed by mock the OfflinePageModel
if we're in a testing environment.

BUG=644570

Committed: https://crrev.com/dd2258ce9e678e3bdbcfe814649851882dfe8118
Cr-Commit-Position: refs/heads/master@{#417465}
==========

[commit-bot: I haz the power, 2016-09-09 00:55:44]

Patchset 9 (id:??) landed as
https://crrev.com/dd2258ce9e678e3bdbcfe814649851882dfe8118
Cr-Commit-Position: refs/heads/master@{#417465}