chrome/browser/android/contextualsearch/contextual_search_manager.cc - Issue 2322793002: [Contextual Search] Fetch and display thumbnails returned in resolution response

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/contextualsearch/contextual_search_manager.cc

Issue 2322793002: [Contextual Search] Fetch and display thumbnails returned in resolution response (Closed)

Patch Set: std::unique_ptr Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/contextualsearch/contextual_search_delegate_unittest.cc ('k') | chrome/browser/android/contextualsearch/resolved_search_term.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/contextualsearch/contextual_search_manager.cc

diff --git a/chrome/browser/android/contextualsearch/contextual_search_manager.cc b/chrome/browser/android/contextualsearch/contextual_search_manager.cc

index f3068ef747e754643b0db64d7721d9dc62e27419..af64c650db6c3fd73cf6709f556c4ff4ae925416 100644

--- a/chrome/browser/android/contextualsearch/contextual_search_manager.cc

+++ b/chrome/browser/android/contextualsearch/contextual_search_manager.cc

@@ -139,12 +139,17 @@ void ContextualSearchManager::OnSearchTermResolutionResponse(

base::android::ScopedJavaLocalRef<jstring> j_context_language =

base::android::ConvertUTF8ToJavaString(

env, resolved_search_term.context_language.c_str());

+ base::android::ScopedJavaLocalRef<jstring> j_thumbnail_url =

+ base::android::ConvertUTF8ToJavaString(

+ env,

+ resolved_search_term.thumbnail_url.c_str());

Java_ContextualSearchManager_onSearchTermResolutionResponse(

env, java_manager_, resolved_search_term.is_invalid,

resolved_search_term.response_code, j_search_term, j_display_text,

j_alternate_term, j_mid, resolved_search_term.prevent_preload,

resolved_search_term.selection_start_adjust,

- resolved_search_term.selection_end_adjust, j_context_language);

+ resolved_search_term.selection_end_adjust, j_context_language,

+ j_thumbnail_url);

}

void ContextualSearchManager::OnSurroundingTextAvailable(