Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4967)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

Issue 2322793002: [Contextual Search] Fetch and display thumbnails returned in resolution response (Closed)
Patch Set: std::unique_ptr Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
index 19b5518832d6535fa6a0f4f8bb7cc218c580cd4f..a91d0f31d1882f94313c8f16bec06d65eaf51e58 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
@@ -331,10 +331,12 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
private final int mStartAdjust;
private final int mEndAdjust;
private final String mContextLanguage;
+ private final String mThumbnailUrl;
public FakeResponseOnMainThread(boolean isNetworkUnavailable, int responseCode,
String searchTerm, String displayText, String alternateTerm, String mid,
- boolean doPreventPreload, int startAdjust, int endAdjudst, String contextLanguage) {
+ boolean doPreventPreload, int startAdjust, int endAdjudst, String contextLanguage,
+ String thumbnailUrl) {
mIsNetworkUnavailable = isNetworkUnavailable;
mResponseCode = responseCode;
mSearchTerm = searchTerm;
@@ -345,13 +347,14 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
mStartAdjust = startAdjust;
mEndAdjust = endAdjudst;
mContextLanguage = contextLanguage;
+ mThumbnailUrl = thumbnailUrl;
}
@Override
public void run() {
mFakeServer.handleSearchTermResolutionResponse(mIsNetworkUnavailable, mResponseCode,
mSearchTerm, mDisplayText, mAlternateTerm, mMid, mDoPreventPreload,
- mStartAdjust, mEndAdjust, mContextLanguage);
+ mStartAdjust, mEndAdjust, mContextLanguage, mThumbnailUrl);
}
}
@@ -362,7 +365,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
private void fakeResponse(boolean isNetworkUnavailable, int responseCode,
String searchTerm, String displayText, String alternateTerm, boolean doPreventPreload) {
fakeResponse(isNetworkUnavailable, responseCode, searchTerm, displayText, alternateTerm,
- null, doPreventPreload, 0, 0, "");
+ null, doPreventPreload, 0, 0, "", "");
}
/**
@@ -371,11 +374,11 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
*/
private void fakeResponse(boolean isNetworkUnavailable, int responseCode, String searchTerm,
String displayText, String alternateTerm, String mid, boolean doPreventPreload,
- int startAdjust, int endAdjust, String contextLanguage) {
+ int startAdjust, int endAdjust, String contextLanguage, String thumbnailUrl) {
if (mFakeServer.getSearchTermRequested() != null) {
getInstrumentation().runOnMainSync(new FakeResponseOnMainThread(isNetworkUnavailable,
responseCode, searchTerm, displayText, alternateTerm, mid, doPreventPreload,
- startAdjust, endAdjust, contextLanguage));
+ startAdjust, endAdjust, contextLanguage, thumbnailUrl));
}
}
@@ -2086,7 +2089,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
waitForPanelToPeek();
fakeResponse(false, 200, "Intelligence", "United States Intelligence", "alternate-term",
- null, false, -14, 0, "");
+ null, false, -14, 0, "", "");
waitForSelectionToBe("United States Intelligence");
}

Powered by Google App Engine
This is Rietveld 408576698