Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2322763002: Revert of Require recipe tryjob in CQ (Closed)

Created:
4 years, 3 months ago by martiniss
Modified:
4 years, 3 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Require recipe tryjob in CQ (patchset #1 id:1 of https://codereview.chromium.org/2157503003/ ) Reason for revert: Downstream tester messed up now, see https://crbug.com/644609 Original issue's description: > Require recipe tryjob in CQ > > BUG=628801 > > Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/ac74456f1e697f38598cda9b1c1acedb80702c7a TBR=phajdan.jr@chromium.org,estaab@chromium.org,iannucci@chromium.org NOTRY=true (no try because the tester itself is broken) # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=628801, 644609 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/925b910ac3e7a3560311f4ae7fe387d061bd5ee3

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M infra/config/cq.cfg View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
martiniss
Created Revert of Require recipe tryjob in CQ
4 years, 3 months ago (2016-09-07 22:31:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322763002/1
4 years, 3 months ago (2016-09-07 22:31:55 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/311f99139d26dd10)
4 years, 3 months ago (2016-09-07 22:33:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322763002/40001
4 years, 3 months ago (2016-09-07 22:35:35 UTC) #9
iannucci
lgtm
4 years, 3 months ago (2016-09-07 22:37:27 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 22:38:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/925b910ac3e7a3...

Powered by Google App Engine
This is Rietveld 408576698