Replace CJS_Runtime::Observer with CFX_Runtime<CJS_Runtime>::Observer

Replace CJS_Runtime::Observer with CFX_Runtime<CJS_Runtime>::Observer

Previously, the observer set a flag which conditionalized a null
pointer return.  Now, we just clear the pointer.

Destruction order matters, so add a method to trigger notifications.

Committed: https://pdfium.googlesource.com/pdfium/+/8832fbf53cf71d4d4cb53986d9cfc024edd2bf1f

[Tom Sepez, 2016-09-07 21:56:22]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-09-07 21:56:23]

Lei, for review.

[Tom Sepez, 2016-09-07 22:04:30]

Description was changed from

==========
Replace CJS_Runtime::Observer with CFX_Runtime<<CJS_Runtime>::Observer;

Previously, the observer set a flag which conditionalized a null
pointer return.  Now, we just clear the pointer.

Destruction order changes a little bit, but shouldn't matter since all
we are doing is zeroing a location, not callng back into other code.
==========

to

==========
Replace CJS_Runtime::Observer with CFX_Runtime<CJS_Runtime>::Observer;

Previously, the observer set a flag which conditionalized a null
pointer return.  Now, we just clear the pointer.

Destruction order changes a little bit, but shouldn't matter since all
we are doing is zeroing a location, not callng back into other code.
==========

[Lei Zhang, 2016-09-07 22:06:54]

lgtm

[Tom Sepez, 2016-09-07 22:10:58]

Description was changed from

==========
Replace CJS_Runtime::Observer with CFX_Runtime<CJS_Runtime>::Observer;

Previously, the observer set a flag which conditionalized a null
pointer return.  Now, we just clear the pointer.

Destruction order changes a little bit, but shouldn't matter since all
we are doing is zeroing a location, not callng back into other code.
==========

to

==========
Replace CJS_Runtime::Observer with CFX_Runtime<CJS_Runtime>::Observer

Previously, the observer set a flag which conditionalized a null
pointer return.  Now, we just clear the pointer.

Destruction order changes a little bit, but shouldn't matter since all
we are doing is zeroing a location, not callng back into other code.
==========

[Tom Sepez, 2016-09-07 22:34:58]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-09-07 22:35:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 22:42:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 22:42:34]

Try jobs failed on following builders:
  linux_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/build...)

[Tom Sepez, 2016-09-07 23:58:27]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 23:58:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-07 23:59:02]

Description was changed from

==========
Replace CJS_Runtime::Observer with CFX_Runtime<CJS_Runtime>::Observer

Previously, the observer set a flag which conditionalized a null
pointer return.  Now, we just clear the pointer.

Destruction order changes a little bit, but shouldn't matter since all
we are doing is zeroing a location, not callng back into other code.
==========

to

==========
Replace CJS_Runtime::Observer with CFX_Runtime<CJS_Runtime>::Observer

Previously, the observer set a flag which conditionalized a null
pointer return.  Now, we just clear the pointer.

Destruction order matters, so add a method to trigger notifications.
==========

[Tom Sepez, 2016-09-07 23:59:15]

Lei, I lied, looks like the order matters.

[commit-bot: I haz the power, 2016-09-07 23:59:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 23:59:48]

Dry run: Try jobs failed on following builders:
  android on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/android/builds/674)
  win_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...)

[Lei Zhang, 2016-09-08 00:02:25]

lgtm, hope you can convince the bots to come back from their strike.

[Tom Sepez, 2016-09-08 17:13:34]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-09-08 17:13:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 17:25:57]

Description was changed from

==========
Replace CJS_Runtime::Observer with CFX_Runtime<CJS_Runtime>::Observer

Previously, the observer set a flag which conditionalized a null
pointer return.  Now, we just clear the pointer.

Destruction order matters, so add a method to trigger notifications.
==========

to

==========
Replace CJS_Runtime::Observer with CFX_Runtime<CJS_Runtime>::Observer

Previously, the observer set a flag which conditionalized a null
pointer return.  Now, we just clear the pointer.

Destruction order matters, so add a method to trigger notifications.

Committed:
https://pdfium.googlesource.com/pdfium/+/8832fbf53cf71d4d4cb53986d9cfc024edd2...
==========

[commit-bot: I haz the power, 2016-09-08 17:25:58]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/8832fbf53cf71d4d4cb53986d9cfc024edd2...