Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 2322683003: [Merge-M54] arc: Add support of default and OEM apps. (Closed)

Created:
4 years, 3 months ago by khmel
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, sadrul, Matt Giuca, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, kalyank, yusukes+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Merge-M54] arc: Add support of default and OEM apps. This implements support for default and OEM Arc apps. These apps are visible before OptIn. Activating this when Arc is not opted in starts OptIn flow and schedules deferred launch for this app. User may remove these apps and default apps stay non vosible until explicitly installed again. Oem apps exists in app list OEM folder. Such apps required to be installed in vendor/system Android image or implement auto-install feature. https://drive.google.com/a/google.com/file/d/0B373dspH0jyNWVpMVmhVdWJBeTg/view Preview available here: https://drive.google.com/file/d/0B63tZNwdjs-qby15dXZyUHBSTEU/view BUG=b/30953084 BUG=641130 TEST=Manually on device TEST=Extended unit_tests TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2281743002 Cr-Commit-Position: refs/heads/master@{#415498} (cherry picked from commit 6a710e40ddcc54f50f8279cd41ae19f5d170bd00)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+729 lines, -77 lines) Patch
M chrome/browser/ui/app_list/app_list_syncable_service.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.h View 9 chunks +34 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 20 chunks +191 lines, -67 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_test.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_test.cc View 5 chunks +19 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 4 chunks +70 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_utils.cc View 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/browser/ui/app_list/arc/arc_default_app_list.h View 1 chunk +86 lines, -0 lines 0 comments Download
A chrome/browser/ui/app_list/arc/arc_default_app_list.cc View 1 chunk +189 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.h View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc View 4 chunks +29 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 3 chunks +54 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/test/data/arc_default_apps/test_app1.json View 1 chunk +7 lines, -0 lines 0 comments Download
A chrome/test/data/arc_default_apps/test_app1/icon_100p.png View Binary file 0 comments Download
A chrome/test/data/arc_default_apps/test_app1/icon_200p.png View Binary file 0 comments Download
A chrome/test/data/arc_default_apps/test_app2.json View 1 chunk +7 lines, -0 lines 0 comments Download
A chrome/test/data/arc_default_apps/test_app2/icon_100p.png View Binary file 0 comments Download
A chrome/test/data/arc_default_apps/test_app2/icon_200p.png View Binary file 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322683003/1
4 years, 3 months ago (2016-09-07 21:58:26 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 22:03:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698