Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Unified Diff: content/browser/site_instance_impl.cc

Issue 2322673005: Fix process transfers for blob urls of sites requiring dedicated processes. (Closed)
Patch Set: Fix documentation. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/site_instance_impl.cc
diff --git a/content/browser/site_instance_impl.cc b/content/browser/site_instance_impl.cc
index 897864031ae74fa162c4d3a6e3b8a4fa2779c626..5b94f662e8d40d13cb4888deca732fd8114d3bd9 100644
--- a/content/browser/site_instance_impl.cc
+++ b/content/browser/site_instance_impl.cc
@@ -368,7 +368,8 @@ GURL SiteInstanceImpl::GetEffectiveURL(BrowserContext* browser_context,
// static
bool SiteInstanceImpl::DoesSiteRequireDedicatedProcess(
BrowserContext* browser_context,
- const GURL& effective_url) {
+ const GURL& url) {
+ GURL site_url = GetSiteForURL(browser_context, url);
Charlie Reis 2016/09/09 21:18:23 nit: Let's add a comment explaining why we want th
ncarter (slow) 2016/09/09 21:56:32 Done.
// If --site-per-process is enabled, site isolation is enabled everywhere.
if (SiteIsolationPolicy::UseDedicatedProcessesForAllSites())
return true;
@@ -376,7 +377,7 @@ bool SiteInstanceImpl::DoesSiteRequireDedicatedProcess(
// Let the content embedder enable site isolation for specific URLs.
if (GetContentClient()->IsSupplementarySiteIsolationModeEnabled() &&
GetContentClient()->browser()->DoesSiteRequireDedicatedProcess(
- browser_context, effective_url)) {
+ browser_context, site_url)) {
return true;
}

Powered by Google App Engine
This is Rietveld 408576698