Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: include/v8.h

Issue 2322673004: [api] Add documentation for IndexedPropertyCallbacks. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 089473784cc3a100dadf1e193899561ba2e8a4e7..b73b48bcc5629bb7c50085ab5c9fa8310f3b2d36 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -4630,7 +4630,7 @@ typedef void (*NamedPropertyEnumeratorCallback)(
* CHECK(v8_num(42)->Equals(env.local(), result).FromJust());
* \endcode
*
- * See also `ObjectTemplate::SetNamedPropertyHandler`.
+ * See also `ObjectTemplate::SetHandler`.
*/
typedef void (*GenericNamedPropertyGetterCallback)(
Local<Name> property, const PropertyCallbackInfo<Value>& info);
@@ -4654,7 +4654,7 @@ typedef void (*GenericNamedPropertyGetterCallback)(
* See `PropertyCallbackInfo`.
*
* See also
- * `ObjectTemplate::SetNamedPropertyHandler.`
+ * `ObjectTemplate::SetHandler.`
*/
typedef void (*GenericNamedPropertySetterCallback)(
Local<Name> property, Local<Value> value,
@@ -4679,7 +4679,7 @@ typedef void (*GenericNamedPropertySetterCallback)(
* trigger this interceptor depending on the state of the object.
*
* See also
- * `ObjectTemplate::SetNamedPropertyHandler.`
+ * `ObjectTemplate::SetHandler.`
*/
typedef void (*GenericNamedPropertyQueryCallback)(
Local<Name> property, const PropertyCallbackInfo<Integer>& info);
@@ -4703,7 +4703,7 @@ typedef void (*GenericNamedPropertyQueryCallback)(
* mode instead of returning false, use `info.ShouldThrowOnError()` to determine
* if you are in strict mode.
*
- * See also `ObjectTemplate::SetNamedPropertyHandler.`
+ * See also `ObjectTemplate::SetHandler.`
*/
typedef void (*GenericNamedPropertyDeleterCallback)(
Local<Name> property, const PropertyCallbackInfo<Boolean>& info);
@@ -4734,7 +4734,7 @@ typedef void (*GenericNamedPropertyEnumeratorCallback)(
* isolate, receiver, return value, or whether running in `'use strict'` mode.
* See `PropertyCallbackInfo`.
*
- * See also `ObjectTemplate::SetNamedPropertyHandler`.
+ * See also `ObjectTemplate::SetHandler`.
*/
typedef void (*GenericNamedPropertyDefinerCallback)(
Local<Name> property, const PropertyDescriptor& desc,
@@ -4757,60 +4757,56 @@ typedef void (*GenericNamedPropertyDefinerCallback)(
* \note If GetOwnPropertyDescriptor is intercepted, it will
* always return true, i.e., indicate that the property was found.
*
- * See also `ObjectTemplate::SetNamedPropertyHandler`.
+ * See also `ObjectTemplate::SetHandler`.
*/
typedef void (*GenericNamedPropertyDescriptorCallback)(
Local<Name> property, const PropertyCallbackInfo<Value>& info);
/**
- * Returns the value of the property if the getter intercepts the
- * request. Otherwise, returns an empty handle.
+ * See `v8::GenericNamedPropertyGetterCallback`.
*/
typedef void (*IndexedPropertyGetterCallback)(
uint32_t index,
const PropertyCallbackInfo<Value>& info);
-
/**
- * Returns the value if the setter intercepts the request.
- * Otherwise, returns an empty handle.
+ * See `v8::GenericNamedPropertySetterCallback`.
*/
typedef void (*IndexedPropertySetterCallback)(
uint32_t index,
Local<Value> value,
const PropertyCallbackInfo<Value>& info);
-
/**
- * Returns a non-empty handle if the interceptor intercepts the request.
- * The result is an integer encoding property attributes.
+ * See `v8::GenericNamedPropertyQueryCallback`.
*/
typedef void (*IndexedPropertyQueryCallback)(
uint32_t index,
const PropertyCallbackInfo<Integer>& info);
-
/**
- * Returns a non-empty handle if the deleter intercepts the request.
- * The return value is true if the property could be deleted and false
- * otherwise.
+ * See `v8::GenericNamedPropertyDeleterCallback`.
*/
typedef void (*IndexedPropertyDeleterCallback)(
uint32_t index,
const PropertyCallbackInfo<Boolean>& info);
-
/**
- * Returns an array containing the indices of the properties the
- * indexed property getter intercepts.
+ * See `v8::GenericNamedPropertyEnumeratorCallback`.
*/
typedef void (*IndexedPropertyEnumeratorCallback)(
const PropertyCallbackInfo<Array>& info);
+/**
+ * See `v8::GenericNamedPropertyDefinerCallback`.
+ */
typedef void (*IndexedPropertyDefinerCallback)(
uint32_t index, const PropertyDescriptor& desc,
const PropertyCallbackInfo<Value>& info);
+/**
+ * See `v8::GenericNamedPropertyDescriptorCallback`.
+ */
typedef void (*IndexedPropertyDescriptorCallback)(
uint32_t index, const PropertyCallbackInfo<Value>& info);
@@ -5061,7 +5057,7 @@ enum class PropertyHandlerFlags {
struct NamedPropertyHandlerConfiguration {
NamedPropertyHandlerConfiguration(
- /** Note: getter is required **/
+ /** Note: getter is required */
GenericNamedPropertyGetterCallback getter = 0,
GenericNamedPropertySetterCallback setter = 0,
GenericNamedPropertyQueryCallback query = 0,
@@ -5112,7 +5108,7 @@ struct NamedPropertyHandlerConfiguration {
struct IndexedPropertyHandlerConfiguration {
IndexedPropertyHandlerConfiguration(
- /** Note: getter is required **/
+ /** Note: getter is required */
IndexedPropertyGetterCallback getter = 0,
IndexedPropertySetterCallback setter = 0,
IndexedPropertyQueryCallback query = 0,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698