Sharpen MdTextButton border for fractional scale factors.

Sharpen MdTextButton border for fractional scale factors.

BUG=635611, 635151
Committed: https://crrev.com/e84ef9b0ce92cf74aaad872583e1e757dfb95ad3
Cr-Commit-Position: refs/heads/master@{#417122}

[Evan Stade, 2016-09-07 19:48:32]

Description was changed from

==========
Sharpen MdTextButton border for fractional scale factors.

BUG=635611
==========

to

==========
Sharpen MdTextButton border for fractional scale factors.

BUG=635611,635151
==========

[Evan Stade, 2016-09-07 19:48:32]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-09-07 21:22:37]

LGTM

https://codereview.chromium.org/2322653002/diff/20001/ui/views/controls/butto...
File ui/views/controls/button/md_text_button.cc (right):

https://codereview.chromium.org/2322653002/diff/20001/ui/views/controls/butto...
ui/views/controls/button/md_text_button.cc:244: SetPaintToLayer(true);
It makes me sad that you have to do this.

[Evan Stade, 2016-09-07 22:31:25]

https://codereview.chromium.org/2322653002/diff/20001/ui/views/controls/butto...
File ui/views/controls/button/md_text_button.cc (right):

https://codereview.chromium.org/2322653002/diff/20001/ui/views/controls/butto...
ui/views/controls/button/md_text_button.cc:244: SetPaintToLayer(true);
On 2016/09/07 21:22:37, sky wrote:
> It makes me sad that you have to do this.

yea, me too, an angel is losing its wings. Is there a better way to get
pixel-snappery?

[Evan Stade, 2016-09-07 22:43:41]

https://codereview.chromium.org/2322653002/diff/20001/ui/views/controls/butto...
File ui/views/controls/button/md_text_button.cc (right):

https://codereview.chromium.org/2322653002/diff/20001/ui/views/controls/butto...
ui/views/controls/button/md_text_button.cc:244: SetPaintToLayer(true);
On 2016/09/07 22:31:25, Evan Stade wrote:
> On 2016/09/07 21:22:37, sky wrote:
> > It makes me sad that you have to do this.
> 
> yea, me too, an angel is losing its wings. Is there a better way to get
> pixel-snappery?

I mean, I assume there isn't currently, but perhaps there's a way we can make it
possible?

[Evan Stade, 2016-09-07 22:43:46]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-09-07 22:44:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-09-07 23:30:24]

It may be possible to adjust during painting, but that will have
subtle ramifications that is likely *very* difficult to get right.

I've said it before and I'll say it again, we shouldn't be using DIPs.

  -Scott

On Wed, Sep 7, 2016 at 3:43 PM,  <estade@chromium.org> wrote:
>
>
https://codereview.chromium.org/2322653002/diff/20001/ui/views/controls/butto...
> File ui/views/controls/button/md_text_button.cc (right):
>
>
https://codereview.chromium.org/2322653002/diff/20001/ui/views/controls/butto...
> ui/views/controls/button/md_text_button.cc:244: SetPaintToLayer(true);
> On 2016/09/07 22:31:25, Evan Stade wrote:
>> On 2016/09/07 21:22:37, sky wrote:
>> > It makes me sad that you have to do this.
>>
>> yea, me too, an angel is losing its wings. Is there a better way to
> get
>> pixel-snappery?
>
> I mean, I assume there isn't currently, but perhaps there's a way we can
> make it possible?
>
> https://codereview.chromium.org/2322653002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2016-09-07 23:30:31]

sky@chromium.org changed reviewers:
+ oshima@chromium.org

[sky, 2016-09-07 23:30:51]

+oshima for ickyness do to using DIPs and trying to get nice pixel alignment.

[commit-bot: I haz the power, 2016-09-07 23:57:22]

Description was changed from

==========
Sharpen MdTextButton border for fractional scale factors.

BUG=635611,635151
==========

to

==========
Sharpen MdTextButton border for fractional scale factors.

BUG=635611,635151
==========

[commit-bot: I haz the power, 2016-09-07 23:57:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-07 23:59:11]

Description was changed from

==========
Sharpen MdTextButton border for fractional scale factors.

BUG=635611,635151
==========

to

==========
Sharpen MdTextButton border for fractional scale factors.

BUG=635611,635151

Committed: https://crrev.com/e84ef9b0ce92cf74aaad872583e1e757dfb95ad3
Cr-Commit-Position: refs/heads/master@{#417122}
==========

[commit-bot: I haz the power, 2016-09-07 23:59:12]

Patchset 2 (id:??) landed as
https://crrev.com/e84ef9b0ce92cf74aaad872583e1e757dfb95ad3
Cr-Commit-Position: refs/heads/master@{#417122}