Remove old version navigator content utils APIs

Remove old version navigator content utils APIs

Old version navigator content utils APIs have been kept since r165458. Because
blink bots might ignore dependency with new content module. However, blink bots
is using updated content module which supports new navigator content utils APIs. Thus,
this cl removes the old navigator content utils APIs.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171454

[gyuyoung-inactive, 2014-04-10 05:48:51]

In r165458(https://src.chromium.org/viewvc/blink?view=rev&revision=165458), old
navigator content utils APIs were kept because blink bots might not use updated
content module. However, it looks now is time to remove the old APIs.

[jochen (gone - plz use gerrit), 2014-04-10 07:29:06]

please use BUG=none instead of N/A

https://codereview.chromium.org/232263003/diff/1/public/web/WebViewClient.h
File public/web/WebViewClient.h (right):

https://codereview.chromium.org/232263003/diff/1/public/web/WebViewClient.h#n...
public/web/WebViewClient.h:332: registerProtocolHandler(scheme, baseUrl, url,
title);
you can drop this call entirely, no?

[gyuyoung-inactive, 2014-04-10 07:46:52]

https://codereview.chromium.org/232263003/diff/1/public/web/WebViewClient.h
File public/web/WebViewClient.h (right):

https://codereview.chromium.org/232263003/diff/1/public/web/WebViewClient.h#n...
public/web/WebViewClient.h:332: registerProtocolHandler(scheme, baseUrl, url,
title);
On 2014/04/10 07:29:06, jochen wrote:
> you can drop this call entirely, no?

As far as I know, the content module only override this function. I already
changed it in r246326 of content module. If there is no dependency issue between
blink and content, I think we can drop the old APIs, because new APIs were added
to blink and content module 2 months ago, isn't it ?

[abarth-chromium, 2014-04-10 21:01:31]

On 2014/04/10 07:46:52, gyuyoung wrote:
> https://codereview.chromium.org/232263003/diff/1/public/web/WebViewClient.h
> File public/web/WebViewClient.h (right):
> 
>
https://codereview.chromium.org/232263003/diff/1/public/web/WebViewClient.h#n...
> public/web/WebViewClient.h:332: registerProtocolHandler(scheme, baseUrl, url,
> title);
> On 2014/04/10 07:29:06, jochen wrote:
> > you can drop this call entirely, no?
> 
> As far as I know, the content module only override this function. I already
> changed it in r246326 of content module. If there is no dependency issue
between
> blink and content, I think we can drop the old APIs, because new APIs were
added
> to blink and content module 2 months ago, isn't it ?

Yes, we can drop odd API, typically after a day or two.

[gyuyoung-inactive, 2014-04-11 01:15:11]

On 2014/04/10 21:01:31, abarth wrote:
> On 2014/04/10 07:46:52, gyuyoung wrote:
> > https://codereview.chromium.org/232263003/diff/1/public/web/WebViewClient.h
> > File public/web/WebViewClient.h (right):
> > 
> >
>
https://codereview.chromium.org/232263003/diff/1/public/web/WebViewClient.h#n...
> > public/web/WebViewClient.h:332: registerProtocolHandler(scheme, baseUrl,
url,
> > title);
> > On 2014/04/10 07:29:06, jochen wrote:
> > > you can drop this call entirely, no?
> > 
> > As far as I know, the content module only override this function. I already
> > changed it in r246326 of content module. If there is no dependency issue
> between
> > blink and content, I think we can drop the old APIs, because new APIs were
> added
> > to blink and content module 2 months ago, isn't it ?
> 
> Yes, we can drop odd API, typically after a day or two.

jochen ?

[jochen (gone - plz use gerrit), 2014-04-14 07:01:14]

https://codereview.chromium.org/232263003/diff/20001/public/web/WebViewClient.h
File public/web/WebViewClient.h (right):

https://codereview.chromium.org/232263003/diff/20001/public/web/WebViewClient...
public/web/WebViewClient.h:293: registerProtocolHandler(scheme, baseUrl, url,
title);
sorry, if I was unclear. I think we can delete this line.

https://codereview.chromium.org/232263003/diff/20001/public/web/WebViewClient...
public/web/WebViewClient.h:299: unregisterProtocolHandler(scheme, baseUrl, url);
and this line

https://codereview.chromium.org/232263003/diff/20001/public/web/WebViewClient...
public/web/WebViewClient.h:305: return isProtocolHandlerRegistered(scheme,
baseUrl, url;
and make this return WebCustomHandlersNew;

[gyuyoung-inactive, 2014-04-14 07:34:17]

https://codereview.chromium.org/232263003/diff/20001/public/web/WebViewClient.h
File public/web/WebViewClient.h (right):

https://codereview.chromium.org/232263003/diff/20001/public/web/WebViewClient...
public/web/WebViewClient.h:293: registerProtocolHandler(scheme, baseUrl, url,
title);
On 2014/04/14 07:01:14, jochen wrote:
> sorry, if I was unclear. I think we can delete this line.

No, my bad. Sorry about unneeded function call.

[jochen (gone - plz use gerrit), 2014-04-14 11:04:37]

lgtm

[gyuyoung-inactive, 2014-04-14 11:05:18]

The CQ bit was checked by gyuyoung.kim@samsung.com

[commit-bot: I haz the power, 2014-04-14 11:05:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/232263003/40001

[commit-bot: I haz the power, 2014-04-14 12:16:20]

Change committed as 171454