Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5568)

Unified Diff: chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

Issue 232263002: Console logging for rAc developer errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: platforms Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc
diff --git a/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc b/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc
index c19448b2b6ad123558af8709a42c71e187e4cbee..26ad4c519e5c04eecf836cf034a4dfd247046bcf 100644
--- a/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc
+++ b/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc
@@ -206,8 +206,10 @@ void AutofillDialogControllerAndroid::Show() {
!Java_AutofillDialogControllerAndroid_isDialogAllowed(
env,
invoked_from_same_origin_)) {
- callback_.Run(AutofillManagerDelegate::AutocompleteResultErrorUnsupported,
- NULL);
+ callback_.Run(
+ AutofillManagerDelegate::AutocompleteResultErrorUnsupported,
+ base::ASCIIToUTF16("Form is missing autocomplete attributes."),
+ NULL);
delete this;
return;
}
@@ -326,6 +328,7 @@ void AutofillDialogControllerAndroid::DialogCancel(JNIEnv* env,
jobject obj) {
LogOnCancelMetrics();
callback_.Run(AutofillManagerDelegate::AutocompleteResultErrorCancel,
+ base::string16(),
NULL);
}
@@ -383,6 +386,7 @@ void AutofillDialogControllerAndroid::DialogContinue(
// Callback should be called as late as possible.
callback_.Run(AutofillManagerDelegate::AutocompleteResultSuccess,
+ base::string16(),
&form_structure_);
// This might delete us.
« no previous file with comments | « no previous file | chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698