Issue 23226002: Implement ClassMirror.superinterfaces.

Issue 23226002: Implement ClassMirror.superinterfaces. (Closed)

Created:
7 years, 4 months ago by ahe

Modified:
7 years, 4 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org, zarah, rmacnak, Michael Lippautz (Google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement ClassMirror.superinterfaces. BUG=http://dartbug.com/11863 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=26185

Patch Set 2 : Long lines and caching #

Total comments: 2

Patch Set 3 : Address comments #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+201 lines, -59 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1 2	4 chunks	+19 lines, -4 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_mirrors.dart	View	1	4 chunks	+19 lines, -2 lines	0 comments	Download
M	dart/tests/lib/lib.status	View		2 chunks	+1 line, -1 line	0 comments	Download
A	dart/tests/lib/mirrors/hierarchy_test.dart	View	1 2	1 chunk	+56 lines, -0 lines	0 comments	Download
M	dart/tests/lib/mirrors/mixin_members_test.dart	View		2 chunks	+25 lines, -16 lines	0 comments	Download
M	dart/tests/lib/mirrors/mixin_test.dart	View		9 chunks	+72 lines, -33 lines	0 comments	Download
M	dart/tests/lib/mirrors/stringify.dart	View		3 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/23226002/diff/4001/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/23226002/diff/4001/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode4068 dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:4068: if (element && element.length) ''' This ''' quote ...

7 years, 4 months ago (2013-08-15 06:52:33 UTC) #2

ahe

Thank you, Nicolas! https://codereview.chromium.org/23226002/diff/4001/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/23226002/diff/4001/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode4068 dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:4068: if (element && element.length) ''' On ...

7 years, 4 months ago (2013-08-15 09:58:24 UTC) #3

ahe

7 years, 4 months ago (2013-08-15 11:06:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r26185 (presubmit successful).

Expand Messages | Collapse Messages