Fix and enable RWHVMEditCommandHelperTest.TestEditingCommandDelivery.

Fix and enable RWHVMEditCommandHelperTest.TestEditingCommandDelivery.

BUG=93286
Test=No visible change. Ran the aforementioned test from content_unittests.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262937

[Nico, 2014-04-10 00:03:27]

https://chromiumcodereview.appspot.com/232253002/diff/20001/content/browser/r...
File
content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm
(right):

https://chromiumcodereview.appspot.com/232253002/diff/20001/content/browser/r...
content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm:103:
// Disabled, http://crbug.com/93286.
remove

https://chromiumcodereview.appspot.com/232253002/diff/20001/content/browser/r...
content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm:148:
delete render_widget;
Wasn't this part handled correctly before due to destructor ordering?

[lazyboy, 2014-04-10 00:16:38]

https://chromiumcodereview.appspot.com/232253002/diff/20001/content/browser/r...
File
content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm
(right):

https://chromiumcodereview.appspot.com/232253002/diff/20001/content/browser/r...
content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm:103:
// Disabled, http://crbug.com/93286.
On 2014/04/10 00:03:27, Nico wrote:
> remove

Done.

https://chromiumcodereview.appspot.com/232253002/diff/20001/content/browser/r...
content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm:148:
delete render_widget;
On 2014/04/10 00:03:27, Nico wrote:
> Wasn't this part handled correctly before due to destructor ordering?

Right, the destruction ordering was an issue. I don't know if that used to be
the case while the test got disabled.

The two issues I fixed here are:
1. The |pool| ensures we destroy the cocoa view and associated RWHVMac first.
2. The destruction of render_widget then happens within message_loop, which in
turn calls DeleteSoon for RPH:
~RenderWidgetHostImpl()
  RenderProcessHostImpl::RemoveRoute():
    RenderProcessHostImpl::CleanUp():
      base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);

[Nico, 2014-04-10 01:10:00]

lgtm

[lazyboy, 2014-04-10 01:27:39]

The CQ bit was checked by lazyboy@chromium.org

[commit-bot: I haz the power, 2014-04-10 01:28:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lazyboy@chromium.org/232253002/40001

[commit-bot: I haz the power, 2014-04-10 05:37:54]

Change committed as 262937