Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2322523002: Cleanup page when unloading in embedder tests (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Cleanup page when unloading in embedder tests When unloading a page in the embedder tests we need to cleanup the internal page map so if we load the page a second time we don't get a previously unloaded page. Committed: https://pdfium.googlesource.com/pdfium/+/cb92dc762d5c35232af9f6051b04e9716247d4ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M testing/embedder_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M testing/embedder_test.cpp View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
dsinclair
PTAL.
4 years, 3 months ago (2016-09-07 14:17:41 UTC) #4
Tom Sepez
lgtm
4 years, 3 months ago (2016-09-07 16:02:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322523002/1
4 years, 3 months ago (2016-09-07 16:02:33 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 16:02:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/cb92dc762d5c35232af9f6051b04e9716247...

Powered by Google App Engine
This is Rietveld 408576698