Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2322503005: [Android] Remove support for default isolates in the test runner. (Closed)

Created:
4 years, 3 months ago by jbudorick
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove support for default isolates in the test runner. The checked-in .isolate files don't exist any more. BUG=644407 Committed: https://crrev.com/824469272d7ec1a122036feaadf5cc8a4dc298f7 Cr-Commit-Position: refs/heads/master@{#417681}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M build/android/pylib/gtest/gtest_test_instance.py View 2 chunks +0 lines, -29 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
jbudorick
4 years, 3 months ago (2016-09-08 14:54:00 UTC) #2
rnephew (Reviews Here)
On 2016/09/08 14:54:00, jbudorick wrote: lgtm
4 years, 3 months ago (2016-09-08 14:55:05 UTC) #3
jbudorick
also, +kjellander, because webrtc hooks into this at the moment.
4 years, 3 months ago (2016-09-08 14:55:09 UTC) #5
kjellander_chromium
lgtm we've moved over to GN so this shouldn't affect us. I realize we have ...
4 years, 3 months ago (2016-09-09 07:47:32 UTC) #6
kjellander_chromium
On 2016/09/09 07:47:32, kjellander_chromium wrote: > lgtm > we've moved over to GN so this ...
4 years, 3 months ago (2016-09-09 07:55:28 UTC) #7
jbudorick
On 2016/09/09 07:55:28, kjellander_chromium wrote: > On 2016/09/09 07:47:32, kjellander_chromium wrote: > > lgtm > ...
4 years, 3 months ago (2016-09-09 18:57:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322503005/20001
4 years, 3 months ago (2016-09-09 19:00:03 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 20:09:20 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 20:11:38 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/824469272d7ec1a122036feaadf5cc8a4dc298f7
Cr-Commit-Position: refs/heads/master@{#417681}

Powered by Google App Engine
This is Rietveld 408576698