sdk/lib/_internal/compiler/implementation/universe/function_set.dart - Issue 23225004: Fix a bug where we would emit a noSuchMethod handler in the Object class for Object methods because…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/universe/function_set.dart

Issue 23225004: Fix a bug where we would emit a noSuchMethod handler in the Object class for Object methods because… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/types/union_type_mask.dart ('k') | tests/language/abstract_exact_selector_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/universe/function_set.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/universe/function_set.dart (revision 26305)

+++ sdk/lib/_internal/compiler/implementation/universe/function_set.dart (working copy)

@@ -164,7 +164,8 @@

// If we cannot ensure a method will be found at runtime, we also

// add [noSuchMethod] implementations that apply to [mask] as

// potential targets.

- if (noSuchMethods != null && !mask.willHit(selector, compiler)) {

+ if (noSuchMethods != null

+ && mask.needsNoSuchMethodHandling(selector, compiler)) {

FunctionSetQuery noSuchMethodQuery = noSuchMethods.query(

new TypedSelector(mask, compiler.noSuchMethodSelector),

compiler,