Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Issue 2322493002: [gn] Turn off lsan on mac asan (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Turn off lsan on mac asan Chromium doesn't support lsan with mac's current toolchain. BUG=chromium:644643 NOTRY=true Committed: https://crrev.com/86f119b85d740f9a52fa63ca8195da5d405f8a15 Cr-Commit-Position: refs/heads/master@{#39255}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M infra/mb/mb_config.pyl View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Achenbach
PTAL. Chromium has this off, see: https://cs.chromium.org/chromium/src/tools/mb/mb_config.pyl?q=mb_con&sq=package:chromium&l=423 https://cs.chromium.org/chromium/src/tools/mb/mb_config.pyl?q=mb_con&sq=package:chromium&l=1639 I don't know how it worked for ...
4 years, 3 months ago (2016-09-07 13:50:28 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-07 14:26:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322493002/1
4 years, 3 months ago (2016-09-07 15:27:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 15:30:00 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 15:30:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86f119b85d740f9a52fa63ca8195da5d405f8a15
Cr-Commit-Position: refs/heads/master@{#39255}

Powered by Google App Engine
This is Rietveld 408576698