Fix leaks in class CFGAS_FontMgrImp

Fix leaks in class CFGAS_FontMgrImp

Two leak cases are addressed here:
--In CFGAS_FontMgrImp::LoadFont(), calling LoadFace() is unnecessary
since the following LoadFile() does the exact same thing. Calling
LoadFace() without releasing the loaded face results in a leak;
--|m_Hash2Fonts| in class CFGAS_FontMgrImp owns all the fonts stored
in it. The fonts need to be deleted along with the container.

BUG=pdfium:242
Committed: https://pdfium.googlesource.com/pdfium/+/5c48effa667fbfc7a3ff7f03e73887347975bec5

[Wei Li, 2016-09-08 00:10:14]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 00:10:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 00:11:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 00:11:55]

Dry run: Try jobs failed on following builders:
  android on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/android/builds/675)

[Wei Li, 2016-09-08 00:50:52]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 00:50:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 01:02:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 01:02:05]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-09-08 17:06:52]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Wei Li, 2016-09-08 17:06:53]

pls review, thanks

[dsinclair, 2016-09-08 17:11:01]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-08 17:11:02]

lgtm

[commit-bot: I haz the power, 2016-09-08 17:11:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 17:11:18]

Description was changed from

==========
Fix leaks in class CFGAS_FontMgrImp

Two leak cases are addressed here:
--In CFGAS_FontMgrImp::LoadFont(), calling LoadFace() is unnecessary
since the following LoadFile() does the exact same thing. Calling
LoadFace() without releasing the loaded face results in a leak;
--|m_Hash2Fonts| in class CFGAS_FontMgrImp owns all the fonts stored
in it. The fonts need to be deleted along with the container.

BUG=pdfium:242
==========

to

==========
Fix leaks in class CFGAS_FontMgrImp

Two leak cases are addressed here:
--In CFGAS_FontMgrImp::LoadFont(), calling LoadFace() is unnecessary
since the following LoadFile() does the exact same thing. Calling
LoadFace() without releasing the loaded face results in a leak;
--|m_Hash2Fonts| in class CFGAS_FontMgrImp owns all the fonts stored
in it. The fonts need to be deleted along with the container.

BUG=pdfium:242

Committed:
https://pdfium.googlesource.com/pdfium/+/5c48effa667fbfc7a3ff7f03e73887347975...
==========

[commit-bot: I haz the power, 2016-09-08 17:11:19]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/5c48effa667fbfc7a3ff7f03e73887347975...