scripts/slave/recipe_modules/chromium_tests/chromium_perf.py - Issue 2322453003: Add Android resource_sizes to chromium_tests/chromium_perf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/chromium_perf.py

Issue 2322453003: Add Android resource_sizes to chromium_tests/chromium_perf

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/chromium_tests/chromium_perf.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py b/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py

index 355a41620756a0cc5652885eda9ae9a544c813ef..58e786ac561c4fc202ab44d7cb4f94885445b58b 100644

--- a/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py

+++ b/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py

@@ -59,8 +59,10 @@ def _BaseSpec(bot_type, config_name, platform, target_bits, tests):

def BuildSpec(config_name, perf_id, platform, target_bits):

if platform == 'android':

- # TODO: Run sizes on Android.

- tests = []

+ tests = [

+ steps.ResourceSizesStep('chrome_public_apk', 'ChromePublic.apk'),

+ steps.ResourceSizesStep('system_webview_apk', 'SystemWebView.apk'),

+ ]

else:

tests = [steps.SizesStep('https://chromeperf.appspot.com', perf_id)]

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium_tests/steps.py » ('j') | no next file with comments »