Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2322453002: [heap] Add histogram counters to track GC reasons. (Closed)

Created:
4 years, 3 months ago by ulan
Modified:
4 years, 3 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Add histogram counters to track GC reasons. BUG=chromium:644713 LOG=NO Committed: https://crrev.com/371c7a388fed901c7403aa5afbcbff9ee81ce077 Cr-Commit-Position: refs/heads/master@{#39250}

Patch Set 1 #

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -27 lines) Patch
M src/counters.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap/gc-tracer.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M src/heap/heap.h View 1 1 chunk +25 lines, -22 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
ulan
PTAL
4 years, 3 months ago (2016-09-07 12:50:57 UTC) #3
Michael Lippautz
lgtm, thanks for the comment! (Will hopefully save us from screwing up UMA)
4 years, 3 months ago (2016-09-07 13:03:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322453002/20001
4 years, 3 months ago (2016-09-07 13:04:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 13:30:34 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 13:31:03 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/371c7a388fed901c7403aa5afbcbff9ee81ce077
Cr-Commit-Position: refs/heads/master@{#39250}

Powered by Google App Engine
This is Rietveld 408576698