Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: runtime/vm/parser.h

Issue 23224016: Implement ParameterMirror.metadata. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/parser.h
diff --git a/runtime/vm/parser.h b/runtime/vm/parser.h
index e5e53ec0b0944230e058fb01084a407432841978..5101cfbc52abe84510117f8a708e5b90dcc04f9a 100644
--- a/runtime/vm/parser.h
+++ b/runtime/vm/parser.h
@@ -144,13 +144,14 @@ class Parser : public ValueObject {
// class if the metadata is at the top-level).
static RawObject* ParseMetadata(const Class& cls, intptr_t token_pos);
- // Parse a function func and retrieve parameter information that can not be
+ // Parse a function func and retrieve parameter information that cannot be
// found in its function object. Returns either an error if the parser fails
// (which could be the case for local functions), or a flat array of the size
- // (2*number_of_parameters). For each parameter i in this array, (2*i)
- // contains a bool indicating whether the parameter has been final, and
- // (2*i+1) contains an array of its default values (or null if it has no
- // default values).
+ // (3*number_of_parameters). For each parameter i in this array, (3*i)
+ // contains a bool indicating whether the parameter has been final, (3*i+1)
siva 2013/08/28 23:26:48 Ditto comment about '3' here.
+ // contains an array of its default values (or null if it has no default
+ // values), and (3*i+2) contains an array of metadata (or null if no metadata
+ // was declared).
static RawObject* ParseFunctionParameters(const Function& func);
// Format and print a message with source location.
@@ -382,10 +383,13 @@ class Parser : public ValueObject {
void ParseClassMemberDefinition(ClassDesc* members,
intptr_t metadata_pos);
void ParseFormalParameter(bool allow_explicit_default_value,
+ bool evaluate_metadata,
ParamList* params);
void ParseFormalParameters(bool allow_explicit_default_values,
+ bool evaluate_metadata,
ParamList* params);
void ParseFormalParameterList(bool allow_explicit_default_values,
+ bool evaluate_metadata,
ParamList* params);
void CheckConstFieldsInitialized(const Class& cls);
void CheckConstructors(ClassDesc* members);

Powered by Google App Engine
This is Rietveld 408576698