Implement ParameterMirror.metadata.

runtime/lib/mirrors.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "lib/invocation_mirror.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart_entry.h"
 #include "vm/exceptions.h"
 #include "vm/object_store.h"
@@ skipping 107 matching lines @@
                                               const Instance& owner_mirror) {
   HANDLESCOPE(Isolate::Current());
   const intptr_t implicit_param_count = func.NumImplicitParameters();
   const intptr_t non_implicit_param_count = func.NumParameters() -
                                             implicit_param_count;
   const intptr_t index_of_first_optional_param =
       non_implicit_param_count - func.NumOptionalParameters();
   const intptr_t index_of_first_named_param =
       non_implicit_param_count - func.NumOptionalNamedParameters();
   const Array& results = Array::Handle(Array::New(non_implicit_param_count));
-  const Array& args = Array::Handle(Array::New(8));
+  const Array& args = Array::Handle(Array::New(9));
 
   // Return for synthetic functions and getters.
   if (func.IsGetterFunction() ||
       func.IsImplicitConstructor() ||
       func.IsImplicitGetterFunction() ||
       func.IsImplicitSetterFunction()) {
     return results.raw();
   }
 
   Smi& pos = Smi::Handle();
   String& name = String::Handle();
   Instance& param = Instance::Handle();
   Bool& is_final = Bool::Handle();
   Object& default_value = Object::Handle();
+  Object& metadata = Object::Handle();
 
   // Reparse the function for the following information:
   // * The default value of a parameter.
   // * Whether a parameters has been deflared as final.
   const Object& result = Object::Handle(Parser::ParseFunctionParameters(func));
   if (result.IsError()) {
     ThrowInvokeError(Error::Cast(result));
     UNREACHABLE();
   }
 
   args.SetAt(0, MirrorReference::Handle(MirrorReference::New(func)));
   args.SetAt(2, owner_mirror);
 
   const Array& param_descriptor = Array::Cast(result);
-  ASSERT(param_descriptor.Length() == (2 * non_implicit_param_count));
+  ASSERT(param_descriptor.Length() == (3 * non_implicit_param_count));

[siva, 2013/08/28 23:26:48]

You should probably make 3 a named constant,
const intptr_t kNumEntriesPerParam = 3; or something like that.

(maybe this constant should be in parser.h).

   for (intptr_t i = 0; i < non_implicit_param_count; i++) {
     pos ^= Smi::New(i);
     name ^= func.ParameterNameAt(implicit_param_count + i);
-    is_final ^= param_descriptor.At(i * 2);
-    default_value = param_descriptor.At(i * 2 + 1);
+    is_final ^= param_descriptor.At(i * 3);
+    default_value = param_descriptor.At(i * 3 + 1);
+    metadata = param_descriptor.At(i * 3 + 2);
+
     ASSERT(default_value.IsNull() || default_value.IsInstance());
 
     // Arguments 0 (referent) and 2 (owner) are the same for all parameters. See
     // above.
     args.SetAt(1, name);
     args.SetAt(3, pos);
     args.SetAt(4, (i >= index_of_first_optional_param) ?
         Bool::True() : Bool::False());
     args.SetAt(5, (i >= index_of_first_named_param) ?
         Bool::True() : Bool::False());
     args.SetAt(6, is_final);
     args.SetAt(7, default_value);
+    args.SetAt(8, metadata);
     param ^= CreateMirror(Symbols::_LocalParameterMirrorImpl(), args);
     results.SetAt(i, param);
   }
   results.MakeImmutable();
   return results.raw();
 }
 
 
 static RawInstance* CreateTypeVariableMirror(const TypeParameter& param,
                                              const Instance& owner_mirror) {
@@ skipping 1165 matching lines @@
 }
 
 
 DEFINE_NATIVE_ENTRY(VariableMirror_type, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(MirrorReference, ref, arguments->NativeArgAt(0));
   const Field& field = Field::Handle(ref.GetFieldReferent());
   return field.type();
 }
 
 }  // namespace dart