Rationalize libvpx configurations

Rationalize libvpx configurations

Move --enable-pic to x86 builds. The chromium build systems provides the
actual compiler flags for pic/pie. This particular piece is only used in
some of the x86 assembly.

Move --as=yasm to x86 builds. This bypasses auto-detection and is just a
shortcut to remove a dependency.

Move --enable-realtime-only to all platforms. It was a mistake that this
was missing from mips.

Remove --disable-ccache --disable-install-srcs --disable-unit-tests
--disable-install-docs --disable-examples --disable-install-bins
--disable-install-libs. Only the output of configure is used, not any of
the libvpx build system, so these are superfluous.

Committed: https://crrev.com/bc529987b89931c5e5a530c81a54e70fd8b0fd3a
Cr-Commit-Position: refs/heads/master@{#417679}

[Johann, 2016-09-09 18:05:41]

The CQ bit was checked by johannkoenig@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 18:06:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Johann, 2016-09-09 19:11:11]

johannkoenig@google.com changed reviewers:
+ jzern@google.com

[Johann, 2016-09-09 19:11:12]

almost entirely a non-op. only change is making mips --enable-realtime-only, but
that was pretty obviously an oversight and not an intentional decision.

armv8-linux-gcc also dropped the force- from --target

[commit-bot: I haz the power, 2016-09-09 19:11:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 19:11:36]

Dry run: This issue passed the CQ dry run.

[jzern, 2016-09-09 19:19:59]

On 2016/09/09 19:11:12, Johann wrote:
> almost entirely a non-op. only change is making mips --enable-realtime-only,
but
> that was pretty obviously an oversight and not an intentional decision.
> 
> armv8-linux-gcc also dropped the force- from --target

lgtm

[jzern, 2016-09-09 19:20:19]

jzern@chromium.org changed reviewers:
+ jzern@chromium.org

[jzern, 2016-09-09 19:20:20]

https://codereview.chromium.org/2322363002/diff/1/third_party/libvpx/generate...
File third_party/libvpx/generate_gni.sh (right):

https://codereview.chromium.org/2322363002/diff/1/third_party/libvpx/generate...
third_party/libvpx/generate_gni.sh:315: all_platforms="--enable-external-build
--enable-postproc --enable-multi-res-encoding --enable-temporal-denoising"
you're in bash so you can use += and split the lines a bit more if you wanted

[Johann, 2016-09-09 19:59:15]

https://codereview.chromium.org/2322363002/diff/1/third_party/libvpx/generate...
File third_party/libvpx/generate_gni.sh (right):

https://codereview.chromium.org/2322363002/diff/1/third_party/libvpx/generate...
third_party/libvpx/generate_gni.sh:315: all_platforms="--enable-external-build
--enable-postproc --enable-multi-res-encoding --enable-temporal-denoising"
On 2016/09/09 19:20:20, jzern wrote:
> you're in bash so you can use += and split the lines a bit more if you wanted

I was wondering about that. I didn't see it in this file yet, so I was avoiding
it.

[Johann, 2016-09-09 19:59:20]

The CQ bit was checked by johannkoenig@google.com

[commit-bot: I haz the power, 2016-09-09 20:00:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 20:06:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-09 20:09:22]

Description was changed from

==========
Rationalize libvpx configurations

Move --enable-pic to x86 builds. The chromium build systems provides the
actual compiler flags for pic/pie. This particular piece is only used in
some of the x86 assembly.

Move --as=yasm to x86 builds. This bypasses auto-detection and is just a
shortcut to remove a dependency.

Move --enable-realtime-only to all platforms. It was a mistake that this
was missing from mips.

Remove --disable-ccache --disable-install-srcs --disable-unit-tests
--disable-install-docs --disable-examples --disable-install-bins
--disable-install-libs. Only the output of configure is used, not any of
the libvpx build system, so these are superfluous.
==========

to

==========
Rationalize libvpx configurations

Move --enable-pic to x86 builds. The chromium build systems provides the
actual compiler flags for pic/pie. This particular piece is only used in
some of the x86 assembly.

Move --as=yasm to x86 builds. This bypasses auto-detection and is just a
shortcut to remove a dependency.

Move --enable-realtime-only to all platforms. It was a mistake that this
was missing from mips.

Remove --disable-ccache --disable-install-srcs --disable-unit-tests
--disable-install-docs --disable-examples --disable-install-bins
--disable-install-libs. Only the output of configure is used, not any of
the libvpx build system, so these are superfluous.

Committed: https://crrev.com/bc529987b89931c5e5a530c81a54e70fd8b0fd3a
Cr-Commit-Position: refs/heads/master@{#417679}
==========

[commit-bot: I haz the power, 2016-09-09 20:09:23]

Patchset 1 (id:??) landed as
https://crrev.com/bc529987b89931c5e5a530c81a54e70fd8b0fd3a
Cr-Commit-Position: refs/heads/master@{#417679}