Issue 232233003: ozone: Protect X11-specific code in IME support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 232233003: ozone: Protect X11-specific code in IME support (Closed)

Created:
6 years, 8 months ago by spang

Modified:
6 years, 8 months ago

Reviewers:
Shu Chen, Yuki

CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ozone: Protect X11-specific code in IME support This fixes some build errors for the "chromeos=1 use_ozone=1" build. We need to stub out IME support until we have an ozone implementation. BUG=361341 TEST=chrome --ozone-platform=test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263033

Patch Set 1 #

Patch Set 2 : rebase #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -7 lines)			Patch
M	chrome/browser/extensions/api/input_ime/input_ime_api.cc	View		8 chunks	+12 lines, -7 lines	0 comments	Download
M	chrome/chrome_browser_chromeos.gypi	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/base/ime/ime.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/232233003/20001

6 years, 8 months ago (2014-04-10 16:21:25 UTC) #5

Message was sent while issue was closed.

Change committed as 263033

Expand Messages | Collapse Messages