Chromium Blob hacking

webkit/browser/blob/blob_url_request_job_factory.h

Index: webkit/browser/blob/blob_url_request_job_factory.h
diff --git a/webkit/browser/blob/blob_url_request_job_factory.h b/webkit/browser/blob/blob_url_request_job_factory.h
index 2a78c95d1a6796ae05849d058558951e4b2325d5..6343b88d8b61559831d225a7fec78aea5d4d635e 100644
--- a/webkit/browser/blob/blob_url_request_job_factory.h
+++ b/webkit/browser/blob/blob_url_request_job_factory.h
@@ -7,6 +7,7 @@
 
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
 #include "net/url_request/url_request_job_factory.h"
 #include "webkit/browser/webkit_storage_browser_export.h"
 
@@ -25,14 +26,19 @@ class URLRequest;
 namespace webkit_blob {
 
 class BlobData;
-class BlobStorageController;
+class BlobDataHandle;
 
 class WEBKIT_STORAGE_BROWSER_EXPORT BlobProtocolHandler
     : public net::URLRequestJobFactory::ProtocolHandler {
  public:
-  // |controller|'s lifetime should exceed the lifetime of the ProtocolHandler.
-  BlobProtocolHandler(BlobStorageController* blob_storage_controller,
-                      fileapi::FileSystemContext* file_system_context,
+  // This class does not lookup based on the request's url value.
+  // Instead, caller's associate the blob to be returned with the
+  // request by utilizing this method.

[ericu, 2013/08/21 23:26:09]

Remove comment?  It's confusing, but once understood, seems trivial.

[michaeln, 2013/08/27 23:24:06]

I think a comment that explains that this class does not lookup based on url is
helpful. I've reduced the comment to just that.

[ericu, 2013/08/28 22:01:28]

How about "This class ignores the request's URL and uses the value given to
SetRequestedBlobDataHandle instead."?

[michaeln, 2013/08/28 22:54:47]

Sgtm!

+  static void SetRequestedBlobDataHandle(
+        net::URLRequest* request,
+        scoped_ptr<BlobDataHandle> blob_data_handle);
+
+  BlobProtocolHandler(fileapi::FileSystemContext* file_system_context,
                       base::MessageLoopProxy* file_loop_proxy);
   virtual ~BlobProtocolHandler();
 
@@ -41,12 +47,9 @@ class WEBKIT_STORAGE_BROWSER_EXPORT BlobProtocolHandler
       net::NetworkDelegate* network_delegate) const OVERRIDE;
 
  private:
-  virtual scoped_refptr<BlobData> LookupBlobData(
+  scoped_refptr<BlobData> LookupBlobData(
       net::URLRequest* request) const;
 
-  // No scoped_refptr because |blob_storage_controller_| is owned by the
-  // ProfileIOData, which also owns this ProtocolHandler.
-  BlobStorageController* const blob_storage_controller_;
   const scoped_refptr<fileapi::FileSystemContext> file_system_context_;
   const scoped_refptr<base::MessageLoopProxy> file_loop_proxy_;