Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2322293002: [LayoutNG] Split LayoutOpportunityIterator into separate file (Closed)

Created:
4 years, 3 months ago by eae
Modified:
4 years, 3 months ago
Reviewers:
Gleb Lanbin
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Split LayoutOpportunityIterator into separate file Split the LayoutOpportunityIterator class into separate source & header files ng_layout_opportunity_iterator.h|cc from ng_constraint_space.h|cc BUG=635619 TBR=glebl@chromium.org Committed: https://crrev.com/b53662d7e6db470093f95c4dbdfce3255210b067 Cr-Commit-Position: refs/heads/master@{#417615}

Patch Set 1 #

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -172 lines) Patch
M third_party/WebKit/Source/core/layout/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 2 chunks +0 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 2 chunks +1 line, -137 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h View 1 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc View 1 chunk +148 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322293002/1
4 years, 3 months ago (2016-09-09 13:25:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322293002/20001
4 years, 3 months ago (2016-09-09 13:27:38 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 17:29:31 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 17:33:00 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b53662d7e6db470093f95c4dbdfce3255210b067
Cr-Commit-Position: refs/heads/master@{#417615}

Powered by Google App Engine
This is Rietveld 408576698