Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2322283002: [stubs] Fix performance regression on x64 caused by modified double hole check. (Closed)

Created:
4 years, 3 months ago by Igor Sheludko
Modified:
4 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Fix performance regression on x64 caused by modified double hole check. Compare the whole word on 64-bit architectures with the kHoleNanInt64 value since comparing only upper part produces slightly worse code on x64. Currently TurboFan is not able to fold (array + ((const1 + index*scale) + const)) into single addressing mode: (array + (const + index*scale)). BUG=chromium:645414 Committed: https://crrev.com/0dbc719bb5dcf63f9b8c6acef01c7ea07be6631d Cr-Commit-Position: refs/heads/master@{#39335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M src/code-stub-assembler.cc View 1 chunk +13 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Igor Sheludko
I'm fixing the regression caused by this CL: https://codereview.chromium.org/2321543003/ PTAL
4 years, 3 months ago (2016-09-09 13:20:22 UTC) #2
mvstanton
Thanks for the fix! LGTM.
4 years, 3 months ago (2016-09-12 08:18:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322283002/1
4 years, 3 months ago (2016-09-12 08:24:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 08:56:23 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 08:56:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0dbc719bb5dcf63f9b8c6acef01c7ea07be6631d
Cr-Commit-Position: refs/heads/master@{#39335}

Powered by Google App Engine
This is Rietveld 408576698