ui/base/DEPS - Issue 2322253004: Drag and dropping text, parsable as url

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/base/DEPS

Issue 2322253004: Drag and dropping text, parsable as url (Closed)

Patch Set: Moving url logic out of os_exchange_data Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+jni",	2 "+jni",

3 "+net",	3 "+net",

4 "+skia/ext",	4 "+skia/ext",

5 "+third_party/skia",	5 "+third_party/skia",

6 "+third_party/zlib/zlib.h",	6 "+third_party/zlib/zlib.h",

7 "+ui/display",	7 "+ui/display",

8 "+ui/events",	8 "+ui/events",

9 "+ui/gfx",	9 "+ui/gfx",

10 "+ui/resources/grit/ui_resources.h",	10 "+ui/resources/grit/ui_resources.h",

11 "+ui/resources/grit/ui_unscaled_resources.h",	11 "+ui/resources/grit/ui_unscaled_resources.h",

12 "+ui/resources/grit/webui_resources.h",	12 "+ui/resources/grit/webui_resources.h",

13 "+ui/strings/grit/app_locale_settings.h",	13 "+ui/strings/grit/app_locale_settings.h",

14 "+ui/strings/grit/ui_strings.h",	14 "+ui/strings/grit/ui_strings.h",

	15 "+components/url_formatter/url_fixer.h",
	dyaroshev 2016/09/14 17:12:05 Where is the correct place to put drag_and_drop_ur Where is the correct place to put drag_and_drop_url_utils? url_formatter and ui/base are independent right now Peter Kasting 2016/09/15 21:26:53 I asked sky to comment here, he might know better. Show quoted text On 2016/09/14 17:12:05, dyaroshev wrote: > Where is the correct place to put drag_and_drop_url_utils? url_formatter and > ui/base are independent right now I asked sky to comment here, he might know better. sky 2016/09/15 21:32:50 Components is a huge directory, and once you add t Show quoted text On 2016/09/14 17:12:05, dyaroshev wrote: > Where is the correct place to put drag_and_drop_url_utils? url_formatter and > ui/base are independent right now Components is a huge directory, and once you add this dependency two bad things could happen. url_formatter could get a dependency we don't want in ui/base and it won't readily be obvious to the person making the change. Second it confuses things from a mental model of what components is. By that I mean where does components sit in the layer tree of dependencies? From the developers perspective it's nice to think of components layering on top of ui/base, but that wouldn't be the case if you do that. For theses reasons ui/base shouldn't depend upon components. I see two options. Don't put ui/base/dragdrop/drag_and_drop_url_utils.h in ui/base, or move url_formatter into ui/base. Moving url_formatter into ui/base doesn't feel the greatest, but ui/base is already a bit of a dumping ground for functionality like this.
15 ]	16 ]

OLD	NEW