Drag and dropping text, parsable as url

chrome/browser/ui/views/tabs/tab_strip.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/tabs/tab_strip.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <iterator>
@@ skipping 24 matching lines @@
 #include "chrome/grit/generated_resources.h"
 #include "chrome/grit/theme_resources.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/common/content_switches.h"
 #include "third_party/skia/include/core/SkColorFilter.h"
 #include "third_party/skia/include/effects/SkBlurMaskFilter.h"
 #include "third_party/skia/include/effects/SkLayerDrawLooper.h"
 #include "third_party/skia/include/pathops/SkPathOps.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/base/default_theme_provider.h"
+#include "ui/base/dragdrop/drag_and_drop_url_utils.h"
 #include "ui/base/dragdrop/drag_drop_types.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/material_design/material_design_controller.h"
 #include "ui/base/models/list_selection_model.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/compositor/compositing_recorder.h"
 #include "ui/compositor/paint_recorder.h"
 #include "ui/display/display.h"
 #include "ui/display/screen.h"
 #include "ui/gfx/animation/animation_container.h"
@@ skipping 1548 matching lines @@
 void TabStrip::OnDragEntered(const DropTargetEvent& event) {
   // Force animations to stop, otherwise it makes the index calculation tricky.
   StopAnimating(true);
 
   UpdateDropIndex(event);
 
   GURL url;
   base::string16 title;
 
   // Check whether the event data includes supported drop data.
-  if (event.data().GetURLAndTitle(
-          ui::OSExchangeData::CONVERT_FILENAMES, &url, &title) &&
-      url.is_valid()) {
-    drop_info_->url = url;
+  if (auto url_and_title = ui::TryToInterpretAsURL(

[dyaroshev, 2016/09/14 17:12:05]

I'm still not so sure, how much of this code should actually be deleted. What is
with the CheckFileSupported logic here and drag and drop in browser_root_view?
Who should be responsible for what?

This logic with trying to parse an url here seems useless - we only get here
from browser_root_view, that processes text already. Can we just get rid of it?

[Peter Kasting, 2016/09/15 21:26:52]

Which logic are you referring to specifically?

Maybe the clearest thing to do would be to write a small, separate CL in advance
of this one that just rips out the bits here you think are redundant, so we can
consider whether that refactoring change can Just Land.

+          event.data(), ui::OSExchangeData::CONVERT_FILENAMES)) {
+    if (!url_and_title->first.is_valid())
+      return;
+    drop_info_->url = url_and_title->first;
 
     // For file:// URLs, kick off a MIME type request in case they're dropped.
-    if (url.SchemeIsFile())
-      controller_->CheckFileSupported(url);
+    if (url_and_title->first.SchemeIsFile())
+      controller_->CheckFileSupported(url_and_title->first);
   }
 }
 
 int TabStrip::OnDragUpdated(const DropTargetEvent& event) {
   // Update the drop index even if the file is unsupported, to allow
   // dragging a file to the contents of another tab.
   UpdateDropIndex(event);
 
   if (!drop_info_->file_supported)
     return ui::DragDropTypes::DRAG_NONE;
@@ skipping 11 matching lines @@
 
   const int drop_index = drop_info_->drop_index;
   const bool drop_before = drop_info_->drop_before;
   const bool file_supported = drop_info_->file_supported;
 
   // Hide the drop indicator.
   SetDropIndex(-1, false);
 
   // Do nothing if the file was unsupported or the URL is invalid. The URL may
   // have been changed after |drop_info_| was created.
-  GURL url;
-  base::string16 title;
-  if (!file_supported ||
-      !event.data().GetURLAndTitle(
-           ui::OSExchangeData::CONVERT_FILENAMES, &url, &title) ||
-      !url.is_valid())
+  if (!file_supported)
     return ui::DragDropTypes::DRAG_NONE;
 
-  controller_->PerformDrop(drop_before, drop_index, url);
+  auto url_and_title = ui::TryToInterpretAsURL(
+      event.data(), ui::OSExchangeData::CONVERT_FILENAMES);
+  if (!url_and_title || !url_and_title->first.is_valid())
+    return ui::DragDropTypes::DRAG_NONE;
+
+  controller_->PerformDrop(drop_before, drop_index, url_and_title->first);
 
   return GetDropEffect(event);
 }
 
 void TabStrip::GetAccessibleState(ui::AXViewState* state) {
   state->role = ui::AX_ROLE_TAB_LIST;
 }
 
 views::View* TabStrip::GetTooltipHandlerForPoint(const gfx::Point& point) {
   if (!HitTestPoint(point))
@@ skipping 1215 matching lines @@
           ConvertPointToViewAndGetEventHandler(this, newtab_button_, point);
       if (view)
         return view;
     }
     Tab* tab = FindTabForEvent(point);
     if (tab)
       return ConvertPointToViewAndGetEventHandler(this, tab, point);
   }
   return this;
 }