Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2322233003:
Enable sending frame-specific messages to the correct input router. (Closed)
|
Created:
4 years, 3 months ago by wjmaclean Modified:
4 years, 3 months ago Reviewers:
Charlie Reis CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, kenrb Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable sending frame-specific messages to the correct input router.
Presently RenderFrameHostImpl::Send() does not use its own widget's
input router when sending message, meaning messages to subframes could
be sent to the wrong frame. This was discovered while trying to make
InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for
messages sent to an out-of-process iframe.
Note: this is a re-land of https://codereview.chromium.org/2012933002/
originally committed as
https://crrev.com/7a22bf01ea55475b295e40f5bbfd1add2bc73649
Cr-Commit-Position: refs/heads/master@{#396044}
TBR=creis@chromium.org
BUG=470662
Committed: https://crrev.com/12619bc6504ec48057ddaf02965c7df7b061a2bb
Cr-Commit-Position: refs/heads/master@{#417586}
Patch Set 1 #
Messages
Total messages: 17 (14 generated)
Description was changed from ========== Enable sending frame-specific messages to the correct input router. Presently RenderFrameHostImpl::Send() does not use its own widget's input router when sending message, meaning messages to subframes could be sent to the wrong frame. This was discovered while trying to make InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for messages sent to an out-of-process iframe. Note: this is a re-land of https://codereview.chromium.org/2012933002/ originally committed as https://crrev.com/7a22bf01ea55475b295e40f5bbfd1add2bc73649 Cr-Commit-Position: refs/heads/master@{#396044} BUG=470662 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ========== to ========== Enable sending frame-specific messages to the correct input router. Presently RenderFrameHostImpl::Send() does not use its own widget's input router when sending message, meaning messages to subframes could be sent to the wrong frame. This was discovered while trying to make InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for messages sent to an out-of-process iframe. Note: this is a re-land of https://codereview.chromium.org/2012933002/ originally committed as https://crrev.com/7a22bf01ea55475b295e40f5bbfd1add2bc73649 Cr-Commit-Position: refs/heads/master@{#396044} TBR=creis@chromium.org BUG=470662 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ==========
wjmaclean@chromium.org changed reviewers: + creis@chromium.org
The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Your CL was about to rely on recently removed CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
tryserver.chromium.linux
For more details, see http://crbug.com/617627.
Description was changed from ========== Enable sending frame-specific messages to the correct input router. Presently RenderFrameHostImpl::Send() does not use its own widget's input router when sending message, meaning messages to subframes could be sent to the wrong frame. This was discovered while trying to make InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for messages sent to an out-of-process iframe. Note: this is a re-land of https://codereview.chromium.org/2012933002/ originally committed as https://crrev.com/7a22bf01ea55475b295e40f5bbfd1add2bc73649 Cr-Commit-Position: refs/heads/master@{#396044} TBR=creis@chromium.org BUG=470662 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ========== to ========== Enable sending frame-specific messages to the correct input router. Presently RenderFrameHostImpl::Send() does not use its own widget's input router when sending message, meaning messages to subframes could be sent to the wrong frame. This was discovered while trying to make InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for messages sent to an out-of-process iframe. Note: this is a re-land of https://codereview.chromium.org/2012933002/ originally committed as https://crrev.com/7a22bf01ea55475b295e40f5bbfd1add2bc73649 Cr-Commit-Position: refs/heads/master@{#396044} TBR=creis@chromium.org BUG=470662 ==========
The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by wjmaclean@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Enable sending frame-specific messages to the correct input router. Presently RenderFrameHostImpl::Send() does not use its own widget's input router when sending message, meaning messages to subframes could be sent to the wrong frame. This was discovered while trying to make InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for messages sent to an out-of-process iframe. Note: this is a re-land of https://codereview.chromium.org/2012933002/ originally committed as https://crrev.com/7a22bf01ea55475b295e40f5bbfd1add2bc73649 Cr-Commit-Position: refs/heads/master@{#396044} TBR=creis@chromium.org BUG=470662 ========== to ========== Enable sending frame-specific messages to the correct input router. Presently RenderFrameHostImpl::Send() does not use its own widget's input router when sending message, meaning messages to subframes could be sent to the wrong frame. This was discovered while trying to make InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for messages sent to an out-of-process iframe. Note: this is a re-land of https://codereview.chromium.org/2012933002/ originally committed as https://crrev.com/7a22bf01ea55475b295e40f5bbfd1add2bc73649 Cr-Commit-Position: refs/heads/master@{#396044} TBR=creis@chromium.org BUG=470662 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Enable sending frame-specific messages to the correct input router. Presently RenderFrameHostImpl::Send() does not use its own widget's input router when sending message, meaning messages to subframes could be sent to the wrong frame. This was discovered while trying to make InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for messages sent to an out-of-process iframe. Note: this is a re-land of https://codereview.chromium.org/2012933002/ originally committed as https://crrev.com/7a22bf01ea55475b295e40f5bbfd1add2bc73649 Cr-Commit-Position: refs/heads/master@{#396044} TBR=creis@chromium.org BUG=470662 ========== to ========== Enable sending frame-specific messages to the correct input router. Presently RenderFrameHostImpl::Send() does not use its own widget's input router when sending message, meaning messages to subframes could be sent to the wrong frame. This was discovered while trying to make InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for messages sent to an out-of-process iframe. Note: this is a re-land of https://codereview.chromium.org/2012933002/ originally committed as https://crrev.com/7a22bf01ea55475b295e40f5bbfd1add2bc73649 Cr-Commit-Position: refs/heads/master@{#396044} TBR=creis@chromium.org BUG=470662 Committed: https://crrev.com/12619bc6504ec48057ddaf02965c7df7b061a2bb Cr-Commit-Position: refs/heads/master@{#417586} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/12619bc6504ec48057ddaf02965c7df7b061a2bb Cr-Commit-Position: refs/heads/master@{#417586} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
