Issue 232223005: Knock out injected safe-browsing prefixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 232223005: Knock out injected safe-browsing prefixes. (Closed)

Created:
6 years, 8 months ago by Scott Hess - ex-Googler

Modified:
6 years, 7 months ago

Reviewers:
mattm

CC:
chromium-reviews, jar (doing other things), asvitkine+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Superceeded by https://codereview.chromium.org/263833005/ ] Knock out injected safe-browsing prefixes. The safe-browsing update code has long injected prefixes when a fullhash was seen. This causes incorrect behavior. That case can be detected by observing prefixes in the same chunk as fullhashes, which cannot be sent by the server. BUG=361248

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+224 lines, -7 lines)			Patch
M	chrome/browser/safe_browsing/safe_browsing_database.cc	View	4 chunks	+63 lines, -7 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_database_unittest.cc	View	2 chunks	+99 lines, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_store.cc	View	3 chunks	+55 lines, -0 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

Apologies for the delay - I had it all ready to go, then thought "Maybe ...

6 years, 8 months ago (2014-04-10 00:17:01 UTC) #1

mattm

6 years, 8 months ago (2014-04-10 02:02:41 UTC) #2

This LGTM, but did you see my question about crbug.com/172527 on the email
thread? Doesn't this change increase the impact of that issue?

Expand Messages | Collapse Messages