Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 232223003: Windows chromoting host installation via the NPAPI plugin (Closed)

Created:
6 years, 8 months ago by weitao
Modified:
6 years, 8 months ago
Reviewers:
Sergey Ulanov, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

On Windows, install the chromoting host component via a separate NPAPI call. This sets us up for: 1. installation of the host component using the Omaha native messaging API when it's ready 2. removal of the NPAPI plugin. BUG=134215 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263753

Patch Set 1 #

Patch Set 2 : Update comment #

Total comments: 10

Patch Set 3 : Addressing Jamie's CR feedback. #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : Fix unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -51 lines) Patch
M remoting/host/plugin/host_script_object.h View 1 chunk +6 lines, -0 lines 0 comments Download
M remoting/host/plugin/host_script_object.cc View 1 2 5 chunks +28 lines, -0 lines 0 comments Download
M remoting/host/setup/daemon_controller.h View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M remoting/host/setup/daemon_controller.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M remoting/host/setup/daemon_controller_delegate_linux.h View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/host/setup/daemon_controller_delegate_linux.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M remoting/host/setup/daemon_controller_delegate_mac.h View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/host/setup/daemon_controller_delegate_mac.mm View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M remoting/host/setup/daemon_controller_delegate_win.h View 3 chunks +7 lines, -1 line 0 comments Download
M remoting/host/setup/daemon_controller_delegate_win.cc View 12 chunks +33 lines, -22 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host_unittest.cc View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M remoting/webapp/host_controller.js View 1 2 4 chunks +62 lines, -23 lines 0 comments Download
M remoting/webapp/host_dispatcher.js View 2 chunks +31 lines, -2 lines 0 comments Download
M remoting/webapp/host_setup_dialog.js View 1 chunk +3 lines, -1 line 0 comments Download
M remoting/webapp/js_proto/remoting_proto.js View 1 chunk +5 lines, -0 lines 0 comments Download
M remoting/webapp/remoting.js View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
weitao
PTAL. IT2Me sharing is still done entirely through NPAPI if the host is not installed. ...
6 years, 8 months ago (2014-04-09 23:31:59 UTC) #1
Jamie
https://codereview.chromium.org/232223003/diff/20001/remoting/host/plugin/host_script_object.cc File remoting/host/plugin/host_script_object.cc (right): https://codereview.chromium.org/232223003/diff/20001/remoting/host/plugin/host_script_object.cc#newcode157 remoting/host/plugin/host_script_object.cc:157: method_name == kFuncNameInstallHost || Should this be available only ...
6 years, 8 months ago (2014-04-10 18:29:31 UTC) #2
weitao
PTAL. https://codereview.chromium.org/232223003/diff/20001/remoting/host/plugin/host_script_object.cc File remoting/host/plugin/host_script_object.cc (right): https://codereview.chromium.org/232223003/diff/20001/remoting/host/plugin/host_script_object.cc#newcode157 remoting/host/plugin/host_script_object.cc:157: method_name == kFuncNameInstallHost || It doesn't matter as ...
6 years, 8 months ago (2014-04-10 21:33:47 UTC) #3
Jamie
lgtm
6 years, 8 months ago (2014-04-10 21:50:42 UTC) #4
weitao
The CQ bit was checked by weitaosu@chromium.org
6 years, 8 months ago (2014-04-10 21:51:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/232223003/40001
6 years, 8 months ago (2014-04-10 21:53:33 UTC) #6
weitao
The CQ bit was unchecked by weitaosu@chromium.org
6 years, 8 months ago (2014-04-10 22:06:13 UTC) #7
weitao
The CQ bit was checked by weitaosu@chromium.org
6 years, 8 months ago (2014-04-10 22:22:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/232223003/40002
6 years, 8 months ago (2014-04-10 22:23:07 UTC) #9
Sergey Ulanov
https://codereview.chromium.org/232223003/diff/40002/remoting/webapp/host_setup_dialog.js File remoting/webapp/host_setup_dialog.js (right): https://codereview.chromium.org/232223003/diff/40002/remoting/webapp/host_setup_dialog.js#newcode377 remoting/webapp/host_setup_dialog.js:377: if (installed || navigator.platform == 'Win32') { I think ...
6 years, 8 months ago (2014-04-10 22:40:28 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 00:26:06 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=93473
6 years, 8 months ago (2014-04-11 00:26:06 UTC) #12
weitao
The CQ bit was checked by weitaosu@chromium.org
6 years, 8 months ago (2014-04-14 17:46:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/232223003/70001
6 years, 8 months ago (2014-04-14 17:46:47 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 19:04:39 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-14 19:04:40 UTC) #16
weitao
The CQ bit was checked by weitaosu@chromium.org
6 years, 8 months ago (2014-04-14 23:30:33 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/232223003/70001
6 years, 8 months ago (2014-04-14 23:31:32 UTC) #18
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 00:41:07 UTC) #19
Message was sent while issue was closed. 
Change committed as 263753

Powered by Google App Engine
This is Rietveld 408576698