Simplify caret color calculation in CaretBase::paintCaret()

Simplify caret color calculation in CaretBase::paintCaret()

This patch simplifies caret color calculation in |CaretBase::paintCaret()| by
using |LayoutObject::resolveColor()| for |CSSColorProperty| for specified
|Node| object rather than using parent element's layout object, since color
value for |Text| node and parent element are same.

BUG=n/a
TEST=n/a; no behavior changes

Committed: https://crrev.com/de6470c2e53aca2dbdf27d5985e7b7aff043337e
Cr-Commit-Position: refs/heads/master@{#417548}

[yosin_UTC9, 2016-09-09 06:02:16]

Description was changed from

==========
2016-09-09T15:00:21

BUG=
==========

to

==========
Simplify caret color calculation in CaretBase::paintCaret()

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-09-09 06:02:21]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 06:02:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-09-09 06:05:45]

Description was changed from

==========
Simplify caret color calculation in CaretBase::paintCaret()

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Simplify caret color calculation in CaretBase::paintCaret()

This patch simplifies caret color calculation in |CaretBase::paintCaret()| by
using |LayoutObject::resolveColor()| for |CSSColorProperty| for specified
|Node| object rather than using parent element's layout object, since color
value for |Text| node and parent element are same.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-09-09 07:34:01]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[Xiaocheng, 2016-09-09 07:40:44]

https://codereview.chromium.org/2322193002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/CaretBase.cpp (right):

https://codereview.chromium.org/2322193002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/CaretBase.cpp:207: const Color caretColor
= node->layoutObject()->resolveColor(CSSPropertyColor);
Do you mean |node| is always a |Text|? If so, could you add a DCHECK?

[yosin_UTC9, 2016-09-09 07:41:49]

On 2016/09/09 at 07:40:44, xiaochengh wrote:
>
https://codereview.chromium.org/2322193002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/CaretBase.cpp (right):
> 
>
https://codereview.chromium.org/2322193002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/CaretBase.cpp:207: const Color
caretColor = node->layoutObject()->resolveColor(CSSPropertyColor);
> Do you mean |node| is always a |Text|? If so, could you add a DCHECK?

No, |node| can be |Text| or |Element|.

[Xiaocheng, 2016-09-09 07:47:45]

lgtm

[yosin_UTC9, 2016-09-09 07:52:55]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2016-09-09 07:52:58]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-09-09 07:53:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2016-09-09 07:53:54]

https://codereview.chromium.org/2322193002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/CaretBase.cpp (right):

https://codereview.chromium.org/2322193002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/CaretBase.cpp:207: const Color caretColor
= node->layoutObject()->resolveColor(CSSPropertyColor);
node->layoutObject() exists always?

[yosin_UTC9, 2016-09-09 08:27:21]

https://codereview.chromium.org/2322193002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/CaretBase.cpp (right):

https://codereview.chromium.org/2322193002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/CaretBase.cpp:207: const Color caretColor
= node->layoutObject()->resolveColor(CSSPropertyColor);
On 2016/09/09 at 07:53:54, yoichio wrote:
> node->layoutObject() exists always?

|node| comes from anchor node of VisiblePosition.

[commit-bot: I haz the power, 2016-09-09 10:15:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-09 10:17:29]

Description was changed from

==========
Simplify caret color calculation in CaretBase::paintCaret()

This patch simplifies caret color calculation in |CaretBase::paintCaret()| by
using |LayoutObject::resolveColor()| for |CSSColorProperty| for specified
|Node| object rather than using parent element's layout object, since color
value for |Text| node and parent element are same.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Simplify caret color calculation in CaretBase::paintCaret()

This patch simplifies caret color calculation in |CaretBase::paintCaret()| by
using |LayoutObject::resolveColor()| for |CSSColorProperty| for specified
|Node| object rather than using parent element's layout object, since color
value for |Text| node and parent element are same.

BUG=n/a
TEST=n/a; no behavior changes

Committed: https://crrev.com/de6470c2e53aca2dbdf27d5985e7b7aff043337e
Cr-Commit-Position: refs/heads/master@{#417548}
==========

[commit-bot: I haz the power, 2016-09-09 10:17:30]

Patchset 1 (id:??) landed as
https://crrev.com/de6470c2e53aca2dbdf27d5985e7b7aff043337e
Cr-Commit-Position: refs/heads/master@{#417548}