Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Unified Diff: net/nqe/network_quality_estimator.h

Issue 2322183002: Add Network Quality Estimator (NQE) pref manager (Closed)
Patch Set: rebased, addressed kundaji and ryansturm comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/nqe/network_quality_estimator.h
diff --git a/net/nqe/network_quality_estimator.h b/net/nqe/network_quality_estimator.h
index 45554e85481e3f43783b167f5e40c46bea29ca41..a03020c7e0280008704579c5c1ef4825419ac47d 100644
--- a/net/nqe/network_quality_estimator.h
+++ b/net/nqe/network_quality_estimator.h
@@ -218,6 +218,14 @@ class NET_EXPORT NetworkQualityEstimator
void ReportEffectiveConnectionTypeForTesting(
EffectiveConnectionType effective_connection_type);
+ // Adds and removes |observer| from the list of cache observers.
+ void AddNetworkQualitiesCacheObserver(
+ nqe::internal::NetworkQualityStore::NetworkQualitiesCacheObserver*
+ observer);
+ void RemoveNetworkQualitiesCacheObserver(
+ nqe::internal::NetworkQualityStore::NetworkQualitiesCacheObserver*
+ observer);
+
protected:
// NetworkChangeNotifier::ConnectionTypeObserver implementation:
void OnConnectionTypeChanged(
@@ -285,9 +293,6 @@ class NET_EXPORT NetworkQualityEstimator
// Returns a random double in the range [0.0, 1.0). Virtualized for testing.
virtual double RandDouble() const;
- // Returns a pointer to |network_quality_store_|. Used only for testing.
- nqe::internal::NetworkQualityStore* NetworkQualityStoreForTesting() const;
-
private:
FRIEND_TEST_ALL_PREFIXES(NetworkQualityEstimatorTest,
AdaptiveRecomputationEffectiveConnectionType);

Powered by Google App Engine
This is Rietveld 408576698