Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2322143002: Switch IntersectionObserver to postTask. (Closed)

Created:
4 years, 3 months ago by ojan
Modified:
4 years, 3 months ago
Reviewers:
haraken, Sami, szager1
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch IntersectionObserver to postTask. For our own visibility detection in the render pipeline throttling code we need to have postTask timing instead of idle tasks. If we need that, then web developers will too. Web developers who care about performance will need to wrap their callbacks in requestIdleCallback. Committed: https://crrev.com/31768c865c398d024d8adad8cd5d9f2b182d12c2 Cr-Commit-Position: refs/heads/master@{#417818}

Patch Set 1 #

Patch Set 2 : finish #

Patch Set 3 : use cancellabletaskfactory #

Patch Set 4 : use weakptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -102 lines) Patch
M third_party/WebKit/LayoutTests/intersection-observer/README View 1 1 chunk +15 lines, -58 lines 0 comments Download
M third_party/WebKit/LayoutTests/resources/intersection-observer-helper-functions.js View 1 2 chunks +11 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverController.h View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp View 1 2 3 5 chunks +10 lines, -19 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
ojan
Not sure if I'm doing the task posting correctly in this new WeakPtr world.
4 years, 3 months ago (2016-09-09 18:31:54 UTC) #9
haraken
LGTM
4 years, 3 months ago (2016-09-10 01:34:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322143002/60001
4 years, 3 months ago (2016-09-10 02:19:20 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-10 03:59:46 UTC) #13
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/31768c865c398d024d8adad8cd5d9f2b182d12c2 Cr-Commit-Position: refs/heads/master@{#417818}
4 years, 3 months ago (2016-09-10 04:01:42 UTC) #15
Sami
lgtm.
4 years, 3 months ago (2016-09-12 09:45:02 UTC) #16
szager1
4 years, 3 months ago (2016-09-12 18:07:32 UTC) #17
Message was sent while issue was closed.
late lgtm

Powered by Google App Engine
This is Rietveld 408576698