SkPDF/Tests: imporve test coverage.

SkPDF/Tests: imporve test coverage.

Also: make sure that all SkPDF unit tests are named SkPDF_* to
make testing changes to SkPDF easier.  Other cleanup.

Add test: SkPDF_pdfa_document to verify that flag in public API
works.

SkPDF_JpegIdentification test: test slightly malformed JPEGs to
verify that all code paths work.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2322133003

Committed: https://skia.googlesource.com/skia/+/57f744e3030fec4d1a2b3e9119011904b149a4da

[hal.canary, 2016-09-08 21:12:10]

Description was changed from

==========
SkPDF/Tests: imporve test coverage.

Also: make sure that all SkPDF unit tests are named SkPDF_* to
make testing changes to SkPDF easier.  Other cleanup.

Add test: SkPDF_pdfa_document to verify that flag in public API
works.

SkPDF_JpegIdentification test: test slightly malformed JPEGs to
verify that all code paths work.

BUG=skia:
==========

to

==========
SkPDF/Tests: imporve test coverage.

Also: make sure that all SkPDF unit tests are named SkPDF_* to
make testing changes to SkPDF easier.  Other cleanup.

Add test: SkPDF_pdfa_document to verify that flag in public API
works.

SkPDF_JpegIdentification test: test slightly malformed JPEGs to
verify that all code paths work.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2322133003
==========

[hal.canary, 2016-09-08 21:12:24]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 21:12:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-09-08 21:12:39]

halcanary@google.com changed reviewers:
+ tomhudson@google.com

[hal.canary, 2016-09-08 21:12:39]

PTAL

[commit-bot: I haz the power, 2016-09-08 21:14:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 21:14:43]

Dry run: Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[hal.canary, 2016-09-08 21:20:07]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 21:20:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 22:01:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 22:01:15]

Dry run: This issue passed the CQ dry run.

[tomhudson, 2016-09-09 14:45:49]

lgtm

https://codereview.chromium.org/2322133003/diff/20001/tests/PDFDeflateWStream...
File tests/PDFDeflateWStreamTest.cpp (right):

https://codereview.chromium.org/2322133003/diff/20001/tests/PDFDeflateWStream...
tests/PDFDeflateWStreamTest.cpp:163: SkDeflateWStream deflateWStream2(nullptr);
nit: if we name this "nullWStream" or "emptyWStream" or "invalidWStream" will
the assertion be easier to understand when it fails?

[hal.canary, 2016-09-09 18:19:04]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2016-09-09 18:19:05]

The patchset sent to the CQ was uploaded after l-g-t-m from tomhudson@google.com
Link to the patchset: https://codereview.chromium.org/2322133003/#ps40001
(title: "toms nit")

[commit-bot: I haz the power, 2016-09-09 18:19:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-09-09 18:19:13]

https://codereview.chromium.org/2322133003/diff/20001/tests/PDFDeflateWStream...
File tests/PDFDeflateWStreamTest.cpp (right):

https://codereview.chromium.org/2322133003/diff/20001/tests/PDFDeflateWStream...
tests/PDFDeflateWStreamTest.cpp:163: SkDeflateWStream deflateWStream2(nullptr);
On 2016/09/09 14:45:49, tomhudson wrote:
> nit: if we name this "nullWStream" or "emptyWStream" or "invalidWStream" will
> the assertion be easier to understand when it fails?

Done.

[commit-bot: I haz the power, 2016-09-09 18:42:01]

Description was changed from

==========
SkPDF/Tests: imporve test coverage.

Also: make sure that all SkPDF unit tests are named SkPDF_* to
make testing changes to SkPDF easier.  Other cleanup.

Add test: SkPDF_pdfa_document to verify that flag in public API
works.

SkPDF_JpegIdentification test: test slightly malformed JPEGs to
verify that all code paths work.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2322133003
==========

to

==========
SkPDF/Tests: imporve test coverage.

Also: make sure that all SkPDF unit tests are named SkPDF_* to
make testing changes to SkPDF easier.  Other cleanup.

Add test: SkPDF_pdfa_document to verify that flag in public API
works.

SkPDF_JpegIdentification test: test slightly malformed JPEGs to
verify that all code paths work.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2322133003

Committed:
https://skia.googlesource.com/skia/+/57f744e3030fec4d1a2b3e9119011904b149a4da
==========

[commit-bot: I haz the power, 2016-09-09 18:42:02]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/57f744e3030fec4d1a2b3e9119011904b149a4da