Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2031)

Unified Diff: appengine/findit/model/crash/fracas_crash_analysis.py

Issue 2322133002: [Findit] Add cracas_crash_analysis (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/crash/fracas_crash_analysis.py
diff --git a/appengine/findit/model/crash/fracas_crash_analysis.py b/appengine/findit/model/crash/fracas_crash_analysis.py
index d1214a3fb5e6c8e4a21d79576d2a66a80a41aa5a..dffd69bad694f46b82a2e7d4d9a509ec6cf89f99 100644
--- a/appengine/findit/model/crash/fracas_crash_analysis.py
+++ b/appengine/findit/model/crash/fracas_crash_analysis.py
@@ -7,30 +7,13 @@ import json
from google.appengine.ext import ndb
-from model.crash.crash_analysis import CrashAnalysis
+from model.crash.chrome_crash_analysis import ChromeCrashAnalysis
-class FracasCrashAnalysis(CrashAnalysis):
- """Represents an analysis of a Chrome crash."""
- # Customized properties for Fracas crash.
- historical_metadata = ndb.JsonProperty(indexed=False)
- channel = ndb.StringProperty(indexed=False)
-
- def Reset(self):
- super(FracasCrashAnalysis, self).Reset()
- self.historical_metadata = None
- self.channel = None
+class FracasCrashAnalysis(ChromeCrashAnalysis):
+ """Represents an analysis of a Chrome crash on Fracas."""
@staticmethod
def _CreateKey(crash_identifiers):
return ndb.Key('FracasCrashAnalysis', hashlib.sha1(
json.dumps(crash_identifiers, sort_keys=True)).hexdigest())
-
- @classmethod
- def Get(cls, crash_identifiers):
- return cls._CreateKey(crash_identifiers).get()
-
- @classmethod
- def Create(cls, crash_identifiers):
- analysis = cls(key=cls._CreateKey(crash_identifiers))
- return analysis

Powered by Google App Engine
This is Rietveld 408576698