Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: appengine/findit/model/crash/chrome_crash_analysis.py

Issue 2322133002: [Findit] Add cracas_crash_analysis (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/crash/chrome_crash_analysis.py
diff --git a/appengine/findit/model/crash/fracas_crash_analysis.py b/appengine/findit/model/crash/chrome_crash_analysis.py
similarity index 67%
copy from appengine/findit/model/crash/fracas_crash_analysis.py
copy to appengine/findit/model/crash/chrome_crash_analysis.py
index d1214a3fb5e6c8e4a21d79576d2a66a80a41aa5a..6f17ba16b8afd03bd5b94185681b607729177ffd 100644
--- a/appengine/findit/model/crash/fracas_crash_analysis.py
+++ b/appengine/findit/model/crash/chrome_crash_analysis.py
@@ -10,21 +10,20 @@ from google.appengine.ext import ndb
from model.crash.crash_analysis import CrashAnalysis
-class FracasCrashAnalysis(CrashAnalysis):
- """Represents an analysis of a Chrome crash."""
+class ChromeCrashAnalysis(CrashAnalysis):
+ """Represents an analysis of a Chrome Crash (Cracas or Fracas)."""
# Customized properties for Fracas crash.
historical_metadata = ndb.JsonProperty(indexed=False)
channel = ndb.StringProperty(indexed=False)
def Reset(self):
- super(FracasCrashAnalysis, self).Reset()
+ super(ChromeCrashAnalysis, self).Reset()
self.historical_metadata = None
self.channel = None
@staticmethod
def _CreateKey(crash_identifiers):
- return ndb.Key('FracasCrashAnalysis', hashlib.sha1(
- json.dumps(crash_identifiers, sort_keys=True)).hexdigest())
+ raise NotImplementedError()
@classmethod
def Get(cls, crash_identifiers):
@@ -32,5 +31,4 @@ class FracasCrashAnalysis(CrashAnalysis):
@classmethod
def Create(cls, crash_identifiers):
- analysis = cls(key=cls._CreateKey(crash_identifiers))
- return analysis
+ return cls(key=cls._CreateKey(crash_identifiers))

Powered by Google App Engine
This is Rietveld 408576698